chrome/browser/extensions/external_pref_extension_provider.cc - Issue 193072: Move StringPiece into the base namespace. It is colliding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_pref_extension_provider.cc

Issue 193072: Move StringPiece into the base namespace. It is colliding (Closed)

Patch Set: take 2 Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_pref_extension_provider.cc

diff --git a/chrome/browser/extensions/external_pref_extension_provider.cc b/chrome/browser/extensions/external_pref_extension_provider.cc

index 7b371ed8e1b1841050aa1c445d1523ee17dd78c0..e0f491fcf719e008d5a2eb23b4921e27342abbe7 100644

--- a/chrome/browser/extensions/external_pref_extension_provider.cc

+++ b/chrome/browser/extensions/external_pref_extension_provider.cc

@@ -58,7 +58,8 @@ void ExternalPrefExtensionProvider::VisitRegisteredExtension(

continue;

}

- if (external_crx.find(FilePath::kParentDirectory) != StringPiece::npos) {

+ if (external_crx.find(FilePath::kParentDirectory) !=

+ base::StringPiece::npos) {

LOG(WARNING) << "Path traversal not allowed in path: "

<< external_crx.c_str();

continue;