Issue 193073: Move StringPiece into the base namespace. This change...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 193073: Move StringPiece into the base namespace. This change... (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Mohamed Mansour

CC:
chromium-reviews_googlegroups.com, jungshik at Google

Base URL:
svn://chrome-svn.jail/chrome/trunk/deps/third_party/hunspell128/

Visibility:
Public.

Description

Move StringPiece into the base namespace. This change depends on http://codereview.chromium.org/193072 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25906

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/hunspell/hashmgr.hxx	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/hunspell/hashmgr.cxx	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

Mohamed, do I need to update any readme or create patch files?

11 years, 3 months ago (2009-09-10 18:25:53 UTC) #1

Mohamed Mansour

11 years, 3 months ago (2009-09-10 19:39:09 UTC) #2

On 2009/09/10 18:25:53, tony wrote:
> Mohamed, do I need to update any readme or create patch files?

LGTM, no you don't need to update any readme because the changes you made are
already chrome hunspell ifdef'd.

Expand Messages | Collapse Messages