Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII(""). (Closed)

Created:
11 years, 11 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -60 lines)			Patch
M	base/directory_watcher_unittest.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/user_script_master_unittest.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/history/starred_url_database_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/importer/firefox2_importer.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/net/url_fetcher_unittest.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_database_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/session_history_uitest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sessions/session_restore_uitest.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/visitedlink_perftest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_plugin_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/unzip_unittest.cc	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	net/base/ssl_test_util.cc	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	net/disk_cache/disk_cache_perftest.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	net/proxy/proxy_script_fetcher_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/tools/tld_cleanup/tld_cleanup.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/dom_serializer_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM - good stuff

Expand Messages | Collapse Messages