chrome/browser/extensions/extensions_service.cc - Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII("").

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII(""). (Closed)

Patch Set: Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extensions_service.cc

diff --git a/chrome/browser/extensions/extensions_service.cc b/chrome/browser/extensions/extensions_service.cc

index f38ff0438d5e9418dffa6569674d1b11610c64a1..cbefb3f64c739377ea98108671d96269dd02dd7f 100644

--- a/chrome/browser/extensions/extensions_service.cc

+++ b/chrome/browser/extensions/extensions_service.cc

@@ -80,7 +80,8 @@ bool ExtensionsServiceBackend::LoadExtensionsFromDirectory(

file_util::FileEnumerator::DIRECTORIES);

for (FilePath child_path = enumerator.Next(); !child_path.value().empty();

child_path = enumerator.Next()) {

- FilePath manifest_path = child_path.Append(Extension::kManifestFilename);

+ FilePath manifest_path =

+ child_path.AppendASCII(Extension::kManifestFilename);

if (!file_util::PathExists(manifest_path)) {

ReportExtensionLoadError(frontend.get(), child_path.ToWStringHack(),

Extension::kInvalidManifestError);