Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: chrome/browser/extensions/extension.cc

Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII(""). (Closed)
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/extension.h ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension.h" 5 #include "chrome/browser/extensions/extension.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 9
10 const FilePath::CharType* Extension::kManifestFilename = 10 const char Extension::kManifestFilename[] = "manifest";
11 FILE_PATH_LITERAL("manifest");
12 11
13 const wchar_t* Extension::kFormatVersionKey = L"format_version"; 12 const wchar_t* Extension::kFormatVersionKey = L"format_version";
14 const wchar_t* Extension::kIdKey = L"id"; 13 const wchar_t* Extension::kIdKey = L"id";
15 const wchar_t* Extension::kNameKey = L"name"; 14 const wchar_t* Extension::kNameKey = L"name";
16 const wchar_t* Extension::kDescriptionKey = L"description"; 15 const wchar_t* Extension::kDescriptionKey = L"description";
17 const wchar_t* Extension::kContentScriptsKey = L"content_scripts"; 16 const wchar_t* Extension::kContentScriptsKey = L"content_scripts";
18 const wchar_t* Extension::kVersionKey = L"version"; 17 const wchar_t* Extension::kVersionKey = L"version";
19 18
20 const char* Extension::kInvalidManifestError = 19 const char* Extension::kInvalidManifestError =
21 "Manifest is missing or invalid."; 20 "Manifest is missing or invalid.";
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 // Copy content scripts (optional). 116 // Copy content scripts (optional).
118 if (content_scripts_.size() > 0) { 117 if (content_scripts_.size() > 0) {
119 ListValue* list_value = new ListValue(); 118 ListValue* list_value = new ListValue();
120 destination->Set(kContentScriptsKey, list_value); 119 destination->Set(kContentScriptsKey, list_value);
121 120
122 for (size_t i = 0; i < content_scripts_.size(); ++i) { 121 for (size_t i = 0; i < content_scripts_.size(); ++i) {
123 list_value->Set(i, Value::CreateStringValue(content_scripts_[i])); 122 list_value->Set(i, Value::CreateStringValue(content_scripts_[i]));
124 } 123 }
125 } 124 }
126 } 125 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension.h ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698