Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3984)

Unified Diff: chrome/common/chrome_plugin_unittest.cc

Issue 18499: Replace cases of Append(FILE_PATH_LITERAL()) with AppendASCII(""). (Closed)
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/visitedlink_perftest.cc ('k') | chrome/common/unzip_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_plugin_unittest.cc
diff --git a/chrome/common/chrome_plugin_unittest.cc b/chrome/common/chrome_plugin_unittest.cc
index 39494a5da42f815364122e6880edce95f30bfe3e..bf901b3e8734645fc313fafcb1e025d25831c6c1 100644
--- a/chrome/common/chrome_plugin_unittest.cc
+++ b/chrome/common/chrome_plugin_unittest.cc
@@ -16,9 +16,9 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace {
+
const wchar_t kDocRoot[] = L"chrome/test/data";
-const FilePath::CharType kPluginFilename[] =
- FILE_PATH_LITERAL("test_chrome_plugin.dll");
+const char kPluginFilename[] = "test_chrome_plugin.dll";
class ChromePluginTest : public testing::Test, public URLRequest::Delegate {
public:
@@ -120,7 +120,7 @@ static void STDCALL CPT_InvokeLater(TestFuncParams::CallbackFunc callback,
void ChromePluginTest::LoadPlugin() {
FilePath path;
PathService::Get(base::DIR_EXE, &path);
- path = path.Append(kPluginFilename);
+ path = path.AppendASCII(kPluginFilename);
plugin_ = ChromePluginLib::Create(path, GetCPBrowserFuncsForBrowser());
// Exchange test APIs with the plugin.
« no previous file with comments | « chrome/browser/visitedlink_perftest.cc ('k') | chrome/common/unzip_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698