Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 178037: Make all of our unit tests be PlatformTests to get an autorelease pool.... (Closed)

Created:
11 years, 3 months ago by pink (ping after 24hrs)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, John Grabowski, Pam (message me for reviews), Paul Godavari, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

Make all of our unit tests be PlatformTests to get an autorelease pool. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25035

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -39 lines) Patch
M chrome/browser/cocoa/autocomplete_text_field_cell_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/background_gradient_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/base_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bubble_window_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller_unittest.mm View 2 chunks +3 lines, -2 lines 2 comments Download
M chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/clear_browsing_data_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/command_observer_bridge_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/custom_home_pages_model_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_shelf_mac_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_util_mac_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/event_utils_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/find_bar_bridge_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/find_bar_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/fullscreen_window_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/gradient_button_cell_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/infobar_container_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/infobar_gradient_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/location_bar_view_mac_unittest.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/nsimage_cache_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/sad_tab_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/search_engine_list_model_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/status_bubble_mac_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_cell_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_controller_unittest.mm View 1 chunk +1 line, -1 line 2 comments Download
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_strip_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_controller_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/toolbar_view_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pink (ping after 24hrs)
11 years, 3 months ago (2009-08-31 18:25:04 UTC) #1
Mark Mentovai
See, I actually read this. LGTM, but check that you intend to disable the ones ...
11 years, 3 months ago (2009-08-31 19:03:23 UTC) #2
pink (ping after 24hrs)
11 years, 3 months ago (2009-08-31 19:06:04 UTC) #3
Thanks for catching these. Leftovers from debugging on SL last week.

http://codereview.chromium.org/178037/diff/1/23
File chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (right):

http://codereview.chromium.org/178037/diff/1/23#newcode63
Line 63: TEST_F(BookmarkEditorControllerTest, DISABLED_UserEditsStuff) {
On 2009/08/31 19:03:24, Mark Mentovai wrote:
> Intentionally disabling this?

Done.

http://codereview.chromium.org/178037/diff/1/6
File chrome/browser/cocoa/tab_controller_unittest.mm (right):

http://codereview.chromium.org/178037/diff/1/6#newcode154
Line 154: TEST_F(TabControllerTest, DISABLED_UserSelection) {
On 2009/08/31 19:03:24, Mark Mentovai wrote:
> This too.

Done.

Powered by Google App Engine
This is Rietveld 408576698