chrome/browser/cocoa/location_bar_view_mac_unittest.mm - Issue 178037: Make all of our unit tests be PlatformTests to get an autorelease pool....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/location_bar_view_mac_unittest.mm

Issue 178037: Make all of our unit tests be PlatformTests to get an autorelease pool.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/cocoa/bookmark_editor_controller_unittest.mm ('K') | « chrome/browser/cocoa/infobar_gradient_view_unittest.mm ('k') | chrome/browser/cocoa/nsimage_cache_unittest.mm » ('j') | chrome/browser/cocoa/tab_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/location_bar_view_mac_unittest.mm

===================================================================

--- chrome/browser/cocoa/location_bar_view_mac_unittest.mm (revision 24882)

+++ chrome/browser/cocoa/location_bar_view_mac_unittest.mm (working copy)

@@ -11,6 +11,7 @@

#include "chrome/browser/cocoa/location_bar_view_mac.h"

#import "chrome/browser/cocoa/cocoa_test_helper.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "testing/platform_test.h"

// TODO(shess): Figure out how to unittest this. The code below was

// testing the hacked-up behavior so you didn't have to be pedantic

@@ -19,7 +20,7 @@

// http://code.google.com/p/chromium/issues/detail?id=9977

#if 0

-class LocationBarViewMacTest : public testing::Test {

+class LocationBarViewMacTest : public PlatformTest {

public:

LocationBarViewMacTest()

: field_([[NSTextField alloc] init]),

@@ -58,7 +59,7 @@

namespace {

-class LocationBarViewMacTest : public testing::Test {

+class LocationBarViewMacTest : public PlatformTest {

public:

LocationBarViewMacTest() {

// Make sure this is wide enough to play games with the cell