chrome/browser/cocoa/bookmark_editor_controller_unittest.mm - Issue 178037: Make all of our unit tests be PlatformTests to get an autorelease pool....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 178037: Make all of our unit tests be PlatformTests to get an autorelease pool.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/cocoa/bookmark_button_cell_unittest.mm ('k') | chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm » ('j') | chrome/browser/cocoa/tab_controller_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

===================================================================

--- chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (revision 24882)

+++ chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (working copy)

@@ -9,8 +9,9 @@

#include "chrome/browser/cocoa/browser_test_helper.h"

#import "chrome/browser/cocoa/cocoa_test_helper.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include "testing/platform_test.h"

-class BookmarkEditorControllerTest : public testing::Test {

+class BookmarkEditorControllerTest : public PlatformTest {

public:

CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc...

BrowserTestHelper helper_;

@@ -59,7 +60,7 @@

isEqual:[controller displayURL]]);

}

-TEST_F(BookmarkEditorControllerTest, UserEditsStuff) {

+TEST_F(BookmarkEditorControllerTest, DISABLED_UserEditsStuff) {

Mark Mentovai 2009/08/31 19:03:24 Intentionally disabling this?

pink (ping after 24hrs) 2009/08/31 19:06:04 Done.

BookmarkModel* model = helper_.profile()->GetBookmarkModel();

const BookmarkNode* parent = model->GetBookmarkBarNode();

const char* url_name = "http://www.zim-bop-a-dee.com/";