Add support for new webkit capability allowing us to update

Add support for new webkit capability allowing us to update
favicons when changed via Javascript.

BUG=none
TEST=BrowserTest.FaviconChange

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45713

[brettw, 2010-04-26 23:28:33]

LGTM

http://codereview.chromium.org/1747015/diff/1/3
File chrome/browser/fav_icon_helper.cc (right):

http://codereview.chromium.org/1747015/diff/1/3#newcode114
chrome/browser/fav_icon_helper.cc:114: // todo(davemoore) Should clear on empty
url. Currently we ignore it.
todo -> TODO

http://codereview.chromium.org/1747015/diff/1/5
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/1747015/diff/1/5#newcode1355
chrome/renderer/render_view.cc:1355: void RenderView::UpdateIconURL(WebFrame*
frame, const GURL& icon_url) {
I would probably put this code in didChangeIcons and not add this extra
function. I suspect the title is split this way for historical reasons, where
the didReceiveTitle was added later for the WebKit API and then we just piped it
through to the old function.

http://codereview.chromium.org/1747015/diff/1/5#newcode1358
chrome/renderer/render_view.cc:1358: Send(new ViewHostMsg_UpdateFavIconURL(
I'd just put this on the same line if I was you, but you can keep it this way if
you prefer.

[Lei Zhang, 2010-04-27 18:58:41]

note: chrome/test/data/onload_change_favicon.html got checked in with the
svn:executable property set. Please fix your revision control system to not do
that.