Add support for new webkit capability allowing us to update

chrome/browser/fav_icon_helper.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/fav_icon_helper.h"
 
 #include "build/build_config.h"
 
 #include "base/callback.h"
 #include "base/ref_counted_memory.h"
@@ skipping 93 matching lines @@
   if (image.empty())
     return;
 
   entry->favicon().set_bitmap(image);
   tab_contents_->NotifyNavigationStateChanged(TabContents::INVALIDATE_TAB);
 }
 
 void FavIconHelper::UpdateFavIconURL(RenderViewHost* render_view_host,
                                      int32 page_id,
                                      const GURL& icon_url) {
+  // todo(davemoore) Should clear on empty url. Currently we ignore it.

[brettw, 2010/04/26 23:28:33]

todo -> TODO

+  // This appears to be what FF does as well.
+  if (icon_url.is_empty())
+    return;
+
   NavigationEntry* entry = GetEntry();
   if (!entry)
     return;
 
   got_fav_icon_url_ = true;
 
   if (!GetFaviconService())
     return;
 
   if (!fav_icon_expired_ && entry->favicon().is_valid() &&
@@ skipping 158 matching lines @@
   int width = image.width();
   int height = image.height();
   if (width > 0 && height > 0) {
     calc_favicon_target_size(&width, &height);
     return skia::ImageOperations::Resize(
           image, skia::ImageOperations::RESIZE_LANCZOS3,
           width, height);
   }
   return image;
 }