Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6157)

Unified Diff: chrome/browser/browser_browsertest.cc

Issue 1747015: Add support for new webkit capability allowing us to update (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/fav_icon_helper.cc » ('j') | chrome/browser/fav_icon_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_browsertest.cc
diff --git a/chrome/browser/browser_browsertest.cc b/chrome/browser/browser_browsertest.cc
index 4abc544bb4a18cacbd4b8999c7d78d064a0f5e3f..6511e7f273c793ceb9882c240761355b4827f3ef 100644
--- a/chrome/browser/browser_browsertest.cc
+++ b/chrome/browser/browser_browsertest.cc
@@ -383,6 +383,24 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, FaviconOfOnloadRedirectToAnchorPage) {
EXPECT_EQ(expected_favicon_url.spec(), entry->favicon().url().spec());
}
+IN_PROC_BROWSER_TEST_F(BrowserTest, FaviconChange) {
+ static const FilePath::CharType* kFile =
+ FILE_PATH_LITERAL("onload_change_favicon.html");
+ GURL file_url(ui_test_utils::GetTestUrl(FilePath(FilePath::kCurrentDirectory),
+ FilePath(kFile)));
+ ASSERT_TRUE(file_url.SchemeIs(chrome::kFileScheme));
+ ui_test_utils::NavigateToURL(browser(), file_url);
+
+ NavigationEntry* entry = browser()->GetSelectedTabContents()->
+ controller().GetActiveEntry();
+ static const FilePath::CharType* kIcon =
+ FILE_PATH_LITERAL("test1.png");
+ GURL expected_favicon_url(
+ ui_test_utils::GetTestUrl(FilePath(FilePath::kCurrentDirectory),
+ FilePath(kIcon)));
+ EXPECT_EQ(expected_favicon_url.spec(), entry->favicon().url().spec());
+}
+
// TODO(sky): get these to run on a Mac.
#if !defined(OS_MACOSX)
IN_PROC_BROWSER_TEST_F(BrowserTest, PhantomTab) {
« no previous file with comments | « no previous file | chrome/browser/fav_icon_helper.cc » ('j') | chrome/browser/fav_icon_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698