Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/fav_icon_helper.cc

Issue 1747015: Add support for new webkit capability allowing us to update (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/common/render_messages_internal.h » ('j') | chrome/renderer/render_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/fav_icon_helper.cc
diff --git a/chrome/browser/fav_icon_helper.cc b/chrome/browser/fav_icon_helper.cc
index d835b3890b0cd6a01ef8118fd2d58c91283179e6..2c6e20827396b28eb0ce8ce71224f38812eff85f 100644
--- a/chrome/browser/fav_icon_helper.cc
+++ b/chrome/browser/fav_icon_helper.cc
@@ -111,6 +111,11 @@ void FavIconHelper::UpdateFavIcon(NavigationEntry* entry,
void FavIconHelper::UpdateFavIconURL(RenderViewHost* render_view_host,
int32 page_id,
const GURL& icon_url) {
+ // todo(davemoore) Should clear on empty url. Currently we ignore it.
brettw 2010/04/26 23:28:33 todo -> TODO
+ // This appears to be what FF does as well.
+ if (icon_url.is_empty())
+ return;
+
NavigationEntry* entry = GetEntry();
if (!entry)
return;
« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/common/render_messages_internal.h » ('j') | chrome/renderer/render_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698