Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1747013: Changes the code to use separate ids namspaces... (Closed)

Created:
10 years, 8 months ago by greggman
Modified:
9 years, 7 months ago
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Changes the code to use separate ids namspaces for buffers, textures, programs, etc.. This is needed to pass GLES2 conformance tests. TEST=old unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45654

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+903 lines, -1013 lines) Patch
M chrome/renderer/ggl/ggl.cc View 3 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 27 chunks +54 lines, -83 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 3 chunks +19 lines, -6 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 6 chunks +13 lines, -11 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 2 3 7 chunks +15 lines, -15 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 2 3 1 chunk +0 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.h View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 1 2 3 4 3 chunks +22 lines, -18 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 1 2 3 3 chunks +0 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 2 3 1 chunk +9 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 46 chunks +413 lines, -415 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_autogen.h View 1 2 3 36 chunks +43 lines, -146 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 8 chunks +22 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 1 2 3 26 chunks +30 lines, -78 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 1 2 3 6 chunks +19 lines, -15 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 2 3 4 chunks +24 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 3 6 chunks +29 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 1 2 3 12 chunks +29 lines, -23 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.h View 1 2 3 4 chunks +10 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 2 3 1 chunk +9 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/renderbuffer_manager_unittest.cc View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.h View 1 2 3 3 chunks +15 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/shader_manager.cc View 1 2 3 1 chunk +18 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 1 2 3 1 chunk +13 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 5 chunks +12 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 1 chunk +20 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 3 4 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, Sorry for the big review but this was pretty major surgery to make ...
10 years, 8 months ago (2010-04-23 21:03:18 UTC) #1
apatrick
Yeah this will break ggl. Let's figure something out. Otherwise the CL looks good.
10 years, 8 months ago (2010-04-26 18:06:41 UTC) #2
greggman
added ggl support
10 years, 8 months ago (2010-04-26 23:37:58 UTC) #3
apatrick_chromium
10 years, 8 months ago (2010-04-27 00:05:35 UTC) #4 
lgtm

Powered by Google App Engine
This is Rietveld 408576698