Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: gpu/command_buffer/service/renderbuffer_manager_unittest.cc

Issue 1747013: Changes the code to use separate ids namspaces... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.cc ('k') | gpu/command_buffer/service/shader_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/renderbuffer_manager_unittest.cc
===================================================================
--- gpu/command_buffer/service/renderbuffer_manager_unittest.cc (revision 45605)
+++ gpu/command_buffer/service/renderbuffer_manager_unittest.cc (working copy)
@@ -24,26 +24,27 @@
};
TEST_F(RenderbufferManagerTest, Basic) {
- const GLuint kRenderbuffer1Id = 1;
- const GLuint kRenderbuffer2Id = 2;
+ const GLuint kClient1Id = 1;
+ const GLuint kService1Id = 11;
+ const GLuint kClient2Id = 2;
// Check we can create renderbuffer.
- manager_.CreateRenderbufferInfo(kRenderbuffer1Id);
+ manager_.CreateRenderbufferInfo(kClient1Id, kService1Id);
// Check renderbuffer got created.
RenderbufferManager::RenderbufferInfo* info1 =
- manager_.GetRenderbufferInfo(kRenderbuffer1Id);
+ manager_.GetRenderbufferInfo(kClient1Id);
ASSERT_TRUE(info1 != NULL);
EXPECT_FALSE(info1->cleared());
info1->set_cleared();
EXPECT_TRUE(info1->cleared());
EXPECT_FALSE(info1->IsDeleted());
- EXPECT_EQ(kRenderbuffer1Id, info1->renderbuffer_id());
+ EXPECT_EQ(kService1Id, info1->service_id());
// Check we get nothing for a non-existent renderbuffer.
- EXPECT_TRUE(manager_.GetRenderbufferInfo(kRenderbuffer2Id) == NULL);
+ EXPECT_TRUE(manager_.GetRenderbufferInfo(kClient2Id) == NULL);
// Check trying to a remove non-existent renderbuffers does not crash.
- manager_.RemoveRenderbufferInfo(kRenderbuffer2Id);
+ manager_.RemoveRenderbufferInfo(kClient2Id);
// Check we can't get the renderbuffer after we remove it.
- manager_.RemoveRenderbufferInfo(kRenderbuffer1Id);
- EXPECT_TRUE(manager_.GetRenderbufferInfo(kRenderbuffer1Id) == NULL);
+ manager_.RemoveRenderbufferInfo(kClient1Id);
+ EXPECT_TRUE(manager_.GetRenderbufferInfo(kClient1Id) == NULL);
}
} // namespace gles2
« no previous file with comments | « gpu/command_buffer/service/renderbuffer_manager.cc ('k') | gpu/command_buffer/service/shader_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698