Issue 1599001: VBoot Reference: Refactor Pass 1: Split {firmware|kernel}_image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1599001: VBoot Reference: Refactor Pass 1: Split {firmware|kernel}_image (Closed)

Created:
10 years, 8 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, gauravsh

Visibility:
Public.

Description

VBoot Reference: Refactor Pass 1: Split {firmware|kernel}_image This CL refactors verified boot firmware and kernel image functions into firmware and userland portions. Data Types and Functions that need to be a part of the final firmware implementation reside in files with "_fw" suffix - firmware_image_fw.{c|h} and kernel_image_fw.{c|h}. Also some Makefile cleanups.

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1127 lines, -1058 lines)			Patch
M	src/platform/vboot_reference/common/utility_stub.c	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/include/firmware_image.h	View	3 chunks	+3 lines, -130 lines	0 comments	Download
A	src/platform/vboot_reference/include/firmware_image_fw.h	View	1 chunk	+142 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/include/kernel_image.h	View	3 chunks	+3 lines, -173 lines	0 comments	Download
A	src/platform/vboot_reference/include/kernel_image_fw.h	View	1 chunk	+183 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/include/tlcl.h	View	1 chunk	+0 lines, -35 lines	0 comments	Download
M	src/platform/vboot_reference/include/utility.h	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	src/platform/vboot_reference/tests/Makefile	View	2 chunks	+23 lines, -33 lines	0 comments	Download
M	src/platform/vboot_reference/utils/Makefile	View	1 chunk	+29 lines, -19 lines	0 comments	Download
M	src/platform/vboot_reference/utils/dumpRSAPublicKey.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/vboot_reference/utils/firmware_image.c	View	8 chunks	+9 lines, -310 lines	0 comments	Download
A	src/platform/vboot_reference/utils/firmware_image_fw.c	View	1 chunk	+323 lines, -0 lines	0 comments	Download
M	src/platform/vboot_reference/utils/kernel_image.c	View	10 chunks	+13 lines, -356 lines	0 comments	Download
A	src/platform/vboot_reference/utils/kernel_image_fw.c	View	1 chunk	+368 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages