Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle. (Closed)

Created:
11 years, 5 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
brettw, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix misleading name and comment of Browser::GetCurrentPageTitle. GetWindowTitleForCurrentTab more accurately describes what this function really does. TEST=none http://crbug.com/16231 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21114

Patch Set 1 #

Patch Set 2 : replace in one more place #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	chrome/browser/browser.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/browser_browsertest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/browser_window_cocoa.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/browser_window_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/panel_controller.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

+brettw Ben seems to not respond to my pings, and from his e-mail I infer ...

11 years, 5 months ago (2009-07-20 19:15:52 UTC) #4

brettw

11 years, 5 months ago (2009-07-20 19:28:04 UTC) #5

I didn't really find the old one confusing, although your new change is fine
too. I guess I was thinking that the view would decide how the title is
displayed and what to display, and this function is exposing to the view the
title of the current tab in the case that the view wants to use it as the window
title.

LGTM

Expand Messages | Collapse Messages