chrome/browser/cocoa/browser_window_cocoa.mm - Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/browser_window_cocoa.mm

Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle. (Closed)

Patch Set: replace in one more place Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/cocoa/browser_window_cocoa.mm b/chrome/browser/cocoa/browser_window_cocoa.mm

index 2493a93495ac602914e6ce4651a60632e6fca840..696e86a54b59a1c29a5985ecb119b0527ebb9465 100644

--- a/chrome/browser/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/cocoa/browser_window_cocoa.mm

@@ -91,7 +91,7 @@ void BrowserWindowCocoa::SelectedTabToolbarSizeChanged(bool is_animating) {

void BrowserWindowCocoa::UpdateTitleBar() {

NSString* newTitle =

- base::SysUTF16ToNSString(browser_->GetCurrentPageTitle());

+ base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());

// Window menu

[NSApp changeWindowsItem:window_ title:newTitle filename:NO];

« no previous file with comments | « chrome/browser/browser_browsertest.cc ('k') | chrome/browser/gtk/browser_window_gtk.cc » ('j') | no next file with comments »