Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: chrome/browser/views/frame/browser_view.cc

Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle. (Closed)
Patch Set: replace in one more place Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.cc ('k') | chrome/browser/views/panel_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/frame/browser_view.h" 5 #include "chrome/browser/views/frame/browser_view.h"
6 6
7 #if defined(OS_LINUX) 7 #if defined(OS_LINUX)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 1100 matching lines...) Expand 10 before | Expand all | Expand 10 after
1111 1111
1112 bool BrowserView::CanMaximize() const { 1112 bool BrowserView::CanMaximize() const {
1113 return true; 1113 return true;
1114 } 1114 }
1115 1115
1116 bool BrowserView::IsModal() const { 1116 bool BrowserView::IsModal() const {
1117 return false; 1117 return false;
1118 } 1118 }
1119 1119
1120 std::wstring BrowserView::GetWindowTitle() const { 1120 std::wstring BrowserView::GetWindowTitle() const {
1121 return UTF16ToWideHack(browser_->GetCurrentPageTitle()); 1121 return UTF16ToWideHack(browser_->GetWindowTitleForCurrentTab());
1122 } 1122 }
1123 1123
1124 views::View* BrowserView::GetInitiallyFocusedView() { 1124 views::View* BrowserView::GetInitiallyFocusedView() {
1125 // We set the frame not focus on creation so this should never be called. 1125 // We set the frame not focus on creation so this should never be called.
1126 NOTREACHED(); 1126 NOTREACHED();
1127 return NULL; 1127 return NULL;
1128 } 1128 }
1129 1129
1130 bool BrowserView::ShouldShowWindowTitle() const { 1130 bool BrowserView::ShouldShowWindowTitle() const {
1131 return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR); 1131 return browser_->SupportsWindowFeature(Browser::FEATURE_TITLEBAR);
(...skipping 764 matching lines...) Expand 10 before | Expand all | Expand 10 after
1896 1896
1897 // static 1897 // static
1898 FindBar* BrowserWindow::CreateFindBar(Browser* browser) { 1898 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
1899 return browser::CreateFindBar(static_cast<BrowserView*>(browser->window())); 1899 return browser::CreateFindBar(static_cast<BrowserView*>(browser->window()));
1900 } 1900 }
1901 1901
1902 // static 1902 // static
1903 void BrowserList::AllBrowsersClosed() { 1903 void BrowserList::AllBrowsersClosed() {
1904 views::Window::CloseAllSecondaryWindows(); 1904 views::Window::CloseAllSecondaryWindows();
1905 } 1905 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.cc ('k') | chrome/browser/views/panel_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698