Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Side by Side Diff: chrome/browser/browser.h

Issue 155534: Fix misleading name and comment of Browser::GetCurrentPageTitle. (Closed)
Patch Set: replace in one more place Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BROWSER_H_ 5 #ifndef CHROME_BROWSER_BROWSER_H_
6 #define CHROME_BROWSER_BROWSER_H_ 6 #define CHROME_BROWSER_BROWSER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 // Save and restore the window position. 155 // Save and restore the window position.
156 std::wstring GetWindowPlacementKey() const; 156 std::wstring GetWindowPlacementKey() const;
157 bool ShouldSaveWindowPlacement() const; 157 bool ShouldSaveWindowPlacement() const;
158 void SaveWindowPlacement(const gfx::Rect& bounds, bool maximized); 158 void SaveWindowPlacement(const gfx::Rect& bounds, bool maximized);
159 gfx::Rect GetSavedWindowBounds() const; 159 gfx::Rect GetSavedWindowBounds() const;
160 bool GetSavedMaximizedState() const; 160 bool GetSavedMaximizedState() const;
161 161
162 // Gets the FavIcon of the page in the selected tab. 162 // Gets the FavIcon of the page in the selected tab.
163 SkBitmap GetCurrentPageIcon() const; 163 SkBitmap GetCurrentPageIcon() const;
164 164
165 // Gets the title of the page in the selected tab. 165 // Gets the title of the window based on the selected tab's title.
166 string16 GetCurrentPageTitle() const; 166 string16 GetWindowTitleForCurrentTab() const;
167 167
168 // Prepares a title string for display (removes embedded newlines, etc). 168 // Prepares a title string for display (removes embedded newlines, etc).
169 static void FormatTitleForDisplay(string16* title); 169 static void FormatTitleForDisplay(string16* title);
170 170
171 // Returns true if the frame should show a distributor logo for this Browser. 171 // Returns true if the frame should show a distributor logo for this Browser.
172 bool ShouldShowDistributorLogo() const; 172 bool ShouldShowDistributorLogo() const;
173 173
174 // OnBeforeUnload handling ////////////////////////////////////////////////// 174 // OnBeforeUnload handling //////////////////////////////////////////////////
175 175
176 // Gives beforeunload handlers the chance to cancel the close. 176 // Gives beforeunload handlers the chance to cancel the close.
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
757 // The browser idle task helps cleanup unused memory resources when idle. 757 // The browser idle task helps cleanup unused memory resources when idle.
758 scoped_ptr<BrowserIdleTimer> idle_task_; 758 scoped_ptr<BrowserIdleTimer> idle_task_;
759 759
760 // Keep track of the encoding auto detect pref. 760 // Keep track of the encoding auto detect pref.
761 BooleanPrefMember encoding_auto_detect_; 761 BooleanPrefMember encoding_auto_detect_;
762 762
763 DISALLOW_COPY_AND_ASSIGN(Browser); 763 DISALLOW_COPY_AND_ASSIGN(Browser);
764 }; 764 };
765 765
766 #endif // CHROME_BROWSER_BROWSER_H_ 766 #endif // CHROME_BROWSER_BROWSER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698