Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 153001: Fix 15 coverity complaints.... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)
Modified:
9 years, 6 months ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Fix 15 coverity complaints. Most of the changes are cosmetic, but there is also a memory leak in CreateExpiredServer. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M net/disk_cache/disk_cache_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mapped_file.h View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mapped_file_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mapped_file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/dump_cache.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M net/tools/dump_cache/dump_files.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rvargas (doing something else)
11 years, 5 months ago (2009-07-01 21:36:15 UTC) #1
rvargas (doing something else)
+nsylvain
11 years, 5 months ago (2009-07-01 23:44:17 UTC) #2
Nicolas Sylvain
11 years, 5 months ago (2009-07-01 23:48:18 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698