Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: net/tools/dump_cache/dump_cache.cc

Issue 153001: Fix 15 coverity complaints.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/mapped_file_win.cc ('k') | net/tools/dump_cache/dump_files.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/dump_cache/dump_cache.cc
===================================================================
--- net/tools/dump_cache/dump_cache.cc (revision 19697)
+++ net/tools/dump_cache/dump_cache.cc (working copy)
@@ -25,11 +25,11 @@
TOOL_NOT_FOUND,
};
-int GetMajorVersion(const std::wstring input_path);
-int DumpContents(const std::wstring input_path);
-int DumpHeaders(const std::wstring input_path);
-int RunSlave(const std::wstring input_path, const std::wstring pipe_number);
-int Upgrade(const std::wstring output_path, HANDLE pipe);
+int GetMajorVersion(const std::wstring& input_path);
+int DumpContents(const std::wstring& input_path);
+int DumpHeaders(const std::wstring& input_path);
+int RunSlave(const std::wstring& input_path, const std::wstring& pipe_number);
+int Upgrade(const std::wstring& output_path, HANDLE pipe);
HANDLE CreateServer(std::wstring* pipe_number);
const char kUpgradeHelp[] =
@@ -67,8 +67,8 @@
}
// Starts a new process, to generate the files.
-int LaunchSlave(const CommandLine& command_line, const std::wstring pipe_number,
- int version) {
+int LaunchSlave(const CommandLine& command_line,
+ const std::wstring& pipe_number, int version) {
// TODO(port): remove this string-munging hackery.
std::wstring hacked_command_line = command_line.command_line_string();
const std::wstring old_exe(L"dump_cache.exe");
« no previous file with comments | « net/disk_cache/mapped_file_win.cc ('k') | net/tools/dump_cache/dump_files.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698