Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Side by Side Diff: net/disk_cache/mapped_file_posix.cc

Issue 153001: Fix 15 coverity complaints.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/disk_cache/mapped_file.h ('k') | net/disk_cache/mapped_file_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/disk_cache/mapped_file.h" 5 #include "net/disk_cache/mapped_file.h"
6 6
7 #include <errno.h> 7 #include <errno.h>
8 #include <sys/mman.h> 8 #include <sys/mman.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "net/disk_cache/disk_cache.h" 11 #include "net/disk_cache/disk_cache.h"
12 12
13 namespace disk_cache { 13 namespace disk_cache {
14 14
15 void* MappedFile::Init(const std::wstring name, size_t size) { 15 void* MappedFile::Init(const std::wstring& name, size_t size) {
16 DCHECK(!init_); 16 DCHECK(!init_);
17 if (init_ || !File::Init(name)) 17 if (init_ || !File::Init(name))
18 return NULL; 18 return NULL;
19 19
20 if (!size) 20 if (!size)
21 size = GetLength(); 21 size = GetLength();
22 22
23 buffer_ = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED, 23 buffer_ = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHARED,
24 platform_file(), 0); 24 platform_file(), 0);
25 init_ = true; 25 init_ = true;
(...skipping 19 matching lines...) Expand all
45 size_t offset = block->offset() + view_size_; 45 size_t offset = block->offset() + view_size_;
46 return Read(block->buffer(), block->size(), offset); 46 return Read(block->buffer(), block->size(), offset);
47 } 47 }
48 48
49 bool MappedFile::Store(const FileBlock* block) { 49 bool MappedFile::Store(const FileBlock* block) {
50 size_t offset = block->offset() + view_size_; 50 size_t offset = block->offset() + view_size_;
51 return Write(block->buffer(), block->size(), offset); 51 return Write(block->buffer(), block->size(), offset);
52 } 52 }
53 53
54 } // namespace disk_cache 54 } // namespace disk_cache
OLDNEW
« no previous file with comments | « net/disk_cache/mapped_file.h ('k') | net/disk_cache/mapped_file_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698