Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: net/disk_cache/mapped_file_win.cc

Issue 153001: Fix 15 coverity complaints.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/disk_cache/mapped_file_posix.cc ('k') | net/tools/dump_cache/dump_cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/disk_cache/mapped_file.h" 5 #include "net/disk_cache/mapped_file.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/disk_cache/disk_cache.h" 8 #include "net/disk_cache/disk_cache.h"
9 9
10 namespace disk_cache { 10 namespace disk_cache {
11 11
12 void* MappedFile::Init(const std::wstring name, size_t size) { 12 void* MappedFile::Init(const std::wstring& name, size_t size) {
13 DCHECK(!init_); 13 DCHECK(!init_);
14 if (init_ || !File::Init(name)) 14 if (init_ || !File::Init(name))
15 return NULL; 15 return NULL;
16 16
17 buffer_ = NULL; 17 buffer_ = NULL;
18 init_ = true; 18 init_ = true;
19 section_ = CreateFileMapping(platform_file(), NULL, PAGE_READWRITE, 0, 19 section_ = CreateFileMapping(platform_file(), NULL, PAGE_READWRITE, 0,
20 static_cast<DWORD>(size), NULL); 20 static_cast<DWORD>(size), NULL);
21 if (!section_) 21 if (!section_)
22 return NULL; 22 return NULL;
(...skipping 22 matching lines...) Expand all
45 size_t offset = block->offset() + view_size_; 45 size_t offset = block->offset() + view_size_;
46 return Read(block->buffer(), block->size(), offset); 46 return Read(block->buffer(), block->size(), offset);
47 } 47 }
48 48
49 bool MappedFile::Store(const FileBlock* block) { 49 bool MappedFile::Store(const FileBlock* block) {
50 size_t offset = block->offset() + view_size_; 50 size_t offset = block->offset() + view_size_;
51 return Write(block->buffer(), block->size(), offset); 51 return Write(block->buffer(), block->size(), offset);
52 } 52 }
53 53
54 } // namespace disk_cache 54 } // namespace disk_cache
OLDNEW
« no previous file with comments | « net/disk_cache/mapped_file_posix.cc ('k') | net/tools/dump_cache/dump_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698