Mac: Make content bubbles wider in languages that have long translations of "Manage" and "Done.

Mac: Make content bubbles wider in languages that have long translations of "Manage" and "Done.

xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller.

BUG=39393
TEST=See bug.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43698

[viettrungluu, 2010-04-06 03:18:56]

http://codereview.chromium.org/1527012/diff/2001/3008
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1527012/diff/2001/3008#newcode102
chrome/browser/cocoa/content_blocked_bubble_controller.mm:102: -
(void)makeWideEnough;
The name of this method is ... uh ... not so great.

http://codereview.chromium.org/1527012/diff/2001/3008#newcode365
chrome/browser/cocoa/content_blocked_bubble_controller.mm:365: frame.origin.x -=
size.width;
Are you really going to always grow it/translate it to the left? That seems
wrong.

Moreover, you might be growing it off the screen.

[Nico, 2010-04-06 04:11:15]

http://codereview.chromium.org/1527012/diff/2001/3008
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1527012/diff/2001/3008#newcode102
chrome/browser/cocoa/content_blocked_bubble_controller.mm:102: -
(void)makeWideEnough;
On 2010/04/06 03:18:56, viettrungluu wrote:
> The name of this method is ... uh ... not so great.

Another constructive comment.

Done?

http://codereview.chromium.org/1527012/diff/2001/3008#newcode365
chrome/browser/cocoa/content_blocked_bubble_controller.mm:365: frame.origin.x -=
size.width;
On 2010/04/06 03:18:56, viettrungluu wrote:
> Are you really going to always grow it/translate it to the left? That seems
> wrong.

Yes. The content blocked bubbbles are all on the right side of the omnibox.

> Moreover, you might be growing it off the screen.

Only if the right side of the chrome window is very far left on the screen.
Furthermore, this seems better than the alternative (keeping the bubble
on-screen, but letting its tip point to some random location).

[viettrungluu, 2010-04-06 04:15:54]

Other than naming, LGTM on the code.

My psychic connection to the .xib files is weak, so I'll have to take your word
that you did appropriate things to them.

http://codereview.chromium.org/1527012/diff/2001/3008
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1527012/diff/2001/3008#newcode102
chrome/browser/cocoa/content_blocked_bubble_controller.mm:102: -
(void)makeWideEnough;
On 2010/04/06 04:11:15, Nico wrote:
> On 2010/04/06 03:18:56, viettrungluu wrote:
> > The name of this method is ... uh ... not so great.
> 
> Another constructive comment.

We aim to please.

> Done?

Hrm. I don't like the "make wide enough" part. How about
-resizeForManageDoneButtons? Or -sizeToFitManageDoneButtons?

[Nico, 2010-04-06 04:17:21]

On Mon, Apr 5, 2010 at 9:15 PM,  <viettrungluu@chromium.org> wrote:
> Other than naming, LGTM on the code.
>
> My psychic connection to the .xib files is weak, so I'll have to take your
> word
> that you did appropriate things to them.
>
>
> http://codereview.chromium.org/1527012/diff/2001/3008
> File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):
>
> http://codereview.chromium.org/1527012/diff/2001/3008#newcode102
> chrome/browser/cocoa/content_blocked_bubble_controller.mm:102: -
> (void)makeWideEnough;
> On 2010/04/06 04:11:15, Nico wrote:
>>
>> On 2010/04/06 03:18:56, viettrungluu wrote:
>> > The name of this method is ... uh ... not so great.
>
>> Another constructive comment.
>
> We aim to please.
>
>> Done?
>
> Hrm. I don't like the "make wide enough" part. How about
> -resizeForManageDoneButtons? Or -sizeToFitManageDoneButtons?

I like -sizeToFitManageDoneButtons. Done.

>
> http://codereview.chromium.org/1527012
>

[TVL, 2010-04-06 12:02:09]

http://codereview.chromium.org/1527012/diff/8001/9008
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1527012/diff/8001/9008#newcode57
chrome/browser/cocoa/content_blocked_bubble_controller.mm:57: const int
kManageDonePadding = 8;
rather then having padding constants, I usually try to make the things in the
nib sized with the padding that is needed/min.  Then at runtime, you simply have
to see if the button grows/shrinks with the right text in it.  If it shrunk,
you're done, if it grows, grow the window by that same amount to keep the
padding at that min.