Mac: Make content bubbles wider in languages that have long translations of "Manage" and "Done.

chrome/browser/cocoa/content_blocked_bubble_controller.mm

Index: chrome/browser/cocoa/content_blocked_bubble_controller.mm
diff --git a/chrome/browser/cocoa/content_blocked_bubble_controller.mm b/chrome/browser/cocoa/content_blocked_bubble_controller.mm
index 684a70b492333cdec6282a3f9c41b92b114b5088..64212749e9800aae0d01f3d65a80319f72d008fa 100644
--- a/chrome/browser/cocoa/content_blocked_bubble_controller.mm
+++ b/chrome/browser/cocoa/content_blocked_bubble_controller.mm
@@ -53,6 +53,8 @@ const int kGeoPadding = 8;
 // Padding between host names in the geolocation bubble.
 const int kGeoHostPadding = 4;
 
+// Minimal padding between "Manage" and "Done" buttons.
+const int kManageDonePadding = 8;

[TVL, 2010/04/06 12:02:09]

rather then having padding constants, I usually try to make the things in the
nib sized with the padding that is needed/min.  Then at runtime, you simply have
to see if the button grows/shrinks with the right text in it.  If it shrunk,
you're done, if it grows, grow the window by that same amount to keep the
padding at that min.

 
 // Like |ReplaceStringPlaceholders(const string16&, const string16&, size_t*)|,
 // but for a NSString formatString.
@@ -97,6 +99,7 @@ NSTextField* LabelWithFrame(NSString* text, const NSRect& frame) {
 - (void)initializeRadioGroup;
 - (void)initializePopupList;
 - (void)initializeGeoLists;
+- (void)makeWideEnoughForManageDoneButtons;
 - (void)popupLinkClicked:(id)sender;
 - (void)clearGeolocationForCurrentHost:(id)sender;
 @end
@@ -348,6 +351,22 @@ NSTextField* LabelWithFrame(NSString* text, const NSRect& frame) {
   [contentsContainer_ setFrame:containerFrame];
 }
 
+- (void)makeWideEnoughForManageDoneButtons {
+  CGFloat actualWidth = NSWidth([[[self window] contentView] frame]);
+  CGFloat requiredWidth = NSMaxX([manageButton_ frame]) + kManageDonePadding +
+      NSWidth([[doneButton_ superview] frame]) - NSMinX([doneButton_ frame]);
+  if (requiredWidth <= actualWidth || !doneButton_ || !manageButton_)
+    return;
+
+  // Resize window, autoresizing takes care of the rest.
+  NSSize size = NSMakeSize(requiredWidth - actualWidth, 0);
+  size = [[[self window] contentView] convertSize:size toView:nil];
+  NSRect frame = [[self window] frame];
+  frame.origin.x -= size.width;
+  frame.size.width += size.width;
+  [[self window] setFrame:frame display:NO];
+}
+
 - (void)awakeFromNib {
   DCHECK([self window]);
   DCHECK_EQ(self, [[self window] delegate]);
@@ -355,6 +374,9 @@ NSTextField* LabelWithFrame(NSString* text, const NSRect& frame) {
   [bubble_ setBubbleType:kWhiteInfoBubble];
   [bubble_ setArrowLocation:kTopRight];
 
+  // Adapt window size to bottom buttons. Do this before all other layouting.
+  [self makeWideEnoughForManageDoneButtons];
+
   [self initializeTitle];
   if (allowBlockRadioGroup_)  // not bound in cookie bubble xib
     [self initializeRadioGroup];