Mac: Make content bubbles wider in languages that have long translations of "Manage" and "Done.

chrome/browser/cocoa/content_blocked_bubble_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/content_blocked_bubble_controller.h"
 
 #include "app/l10n_util.h"
 #include "base/logging.h"
 #include "base/mac_util.h"
 #include "base/string_util.h"
@@ skipping 35 matching lines @@
 
 // Height of the "Clear" button in the geolocation bubble.
 const int kGeoClearButtonHeight = 17;
 
 // General padding between elements in the geolocation bubble.
 const int kGeoPadding = 8;
 
 // Padding between host names in the geolocation bubble.
 const int kGeoHostPadding = 4;
 
+// Minimal padding between "Manage" and "Done" buttons.
+const int kManageDonePadding = 8;

[TVL, 2010/04/06 12:02:09]

rather then having padding constants, I usually try to make the things in the
nib sized with the padding that is needed/min.  Then at runtime, you simply have
to see if the button grows/shrinks with the right text in it.  If it shrunk,
you're done, if it grows, grow the window by that same amount to keep the
padding at that min.

 
 // Like |ReplaceStringPlaceholders(const string16&, const string16&, size_t*)|,
 // but for a NSString formatString.
 NSString* ReplaceNSStringPlaceholders(NSString* formatString,
                                       const string16& a,
                                       size_t* offset) {
   return base::SysUTF16ToNSString(
       ReplaceStringPlaceholders(base::SysNSStringToUTF16(formatString),
                                 a,
                                 offset));
@@ skipping 24 matching lines @@
        parentWindow:(NSWindow*)parentWindow
          anchoredAt:(NSPoint)anchoredAt;
 - (NSButton*)hyperlinkButtonWithFrame:(NSRect)frame
                                 title:(NSString*)title
                                  icon:(NSImage*)icon
                        referenceFrame:(NSRect)referenceFrame;
 - (void)initializeTitle;
 - (void)initializeRadioGroup;
 - (void)initializePopupList;
 - (void)initializeGeoLists;
+- (void)makeWideEnoughForManageDoneButtons;
 - (void)popupLinkClicked:(id)sender;
 - (void)clearGeolocationForCurrentHost:(id)sender;
 @end
 
 @implementation ContentBlockedBubbleController
 
 + (ContentBlockedBubbleController*)
     showForModel:(ContentSettingBubbleModel*)contentSettingBubbleModel
     parentWindow:(NSWindow*)parentWindow
       anchoredAt:(NSPoint)anchor {
@@ skipping 231 matching lines @@
     containerHeight -= kGeoPadding;
 
   // Resize container to fit its subviews, and window to fit the container.
   NSRect windowFrame = [[self window] frame];
   windowFrame.size.height += containerHeight - containerFrame.size.height;
   [[self window] setFrame:windowFrame display:NO];
   containerFrame.size.height = containerHeight;
   [contentsContainer_ setFrame:containerFrame];
 }
 
+- (void)makeWideEnoughForManageDoneButtons {
+  CGFloat actualWidth = NSWidth([[[self window] contentView] frame]);
+  CGFloat requiredWidth = NSMaxX([manageButton_ frame]) + kManageDonePadding +
+      NSWidth([[doneButton_ superview] frame]) - NSMinX([doneButton_ frame]);
+  if (requiredWidth <= actualWidth || !doneButton_ || !manageButton_)
+    return;
+
+  // Resize window, autoresizing takes care of the rest.
+  NSSize size = NSMakeSize(requiredWidth - actualWidth, 0);
+  size = [[[self window] contentView] convertSize:size toView:nil];
+  NSRect frame = [[self window] frame];
+  frame.origin.x -= size.width;
+  frame.size.width += size.width;
+  [[self window] setFrame:frame display:NO];
+}
+
 - (void)awakeFromNib {
   DCHECK([self window]);
   DCHECK_EQ(self, [[self window] delegate]);
 
   [bubble_ setBubbleType:kWhiteInfoBubble];
   [bubble_ setArrowLocation:kTopRight];
 
+  // Adapt window size to bottom buttons. Do this before all other layouting.
+  [self makeWideEnoughForManageDoneButtons];
+
   [self initializeTitle];
   if (allowBlockRadioGroup_)  // not bound in cookie bubble xib
     [self initializeRadioGroup];
   if (contentSettingBubbleModel_->content_type() ==
       CONTENT_SETTINGS_TYPE_POPUPS)
     [self initializePopupList];
   if (contentSettingBubbleModel_->content_type() ==
       CONTENT_SETTINGS_TYPE_GEOLOCATION)
     [self initializeGeoLists];
 }
@@ skipping 87 matching lines @@
   DCHECK(i != popupLinks_.end());
   contentSettingBubbleModel_->OnPopupClicked(i->second);
 }
 
 - (void)clearGeolocationForCurrentHost:(id)sender {
   contentSettingBubbleModel_->OnClearLinkClicked();
   [self close];
 }
 
 @end  // ContentBlockedBubbleController