Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 146093: Relanding focus manager refactoring (Closed)

Created:
11 years, 6 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

This CL removes the last (major) Windows specific part out of the focus manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19617

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -457 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 1 2 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/first_run_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container_view_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/constrained_window_win.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/views/constrained_window_win.cc View 1 2 3 4 2 chunks +1 line, -37 lines 0 comments Download
M chrome/browser/views/download_started_animation_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_win.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/find_bar_win_browsertest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/info_bubble.cc View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents/native_tab_contents_container_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.h View 3 chunks +11 lines, -0 lines 1 comment Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 1 2 3 4 8 chunks +30 lines, -7 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/dragged_tab_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/native_view_photobooth_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/menu/chrome_menu.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native_control.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/native_control_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tabbed_pane.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tree/tree_view.cc View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M views/focus/external_focus_tracker.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M views/focus/focus_manager.h View 1 2 9 chunks +18 lines, -67 lines 0 comments Download
M views/focus/focus_manager.cc View 1 2 9 chunks +13 lines, -211 lines 0 comments Download
A views/focus/focus_manager_gtk.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
A views/focus/focus_manager_win.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M views/view.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M views/view_unittest.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M views/view_win.cc View 1 2 2 chunks +1 line, -13 lines 0 comments Download
M views/views.gyp View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M views/widget/accelerator_handler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M views/widget/root_view.cc View 1 2 3 chunks +4 lines, -17 lines 0 comments Download
M views/widget/widget.h View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M views/widget/widget_win.h View 1 2 5 chunks +11 lines, -6 lines 0 comments Download
M views/widget/widget_win.cc View 1 2 3 4 8 chunks +29 lines, -14 lines 0 comments Download
M views/window/window_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 6 months ago (2009-06-25 19:36:40 UTC) #1
Ben Goodger (Google)
11 years, 6 months ago (2009-06-26 21:18:08 UTC) #2
OK

http://codereview.chromium.org/146093/diff/1319/2048
File chrome/browser/views/tab_contents/tab_contents_view_win.h (right):

http://codereview.chromium.org/146093/diff/1319/2048#newcode31
Line 31: virtual void Unparent();
doesn't need to be virtual

Powered by Google App Engine
This is Rietveld 408576698