Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/views/tab_contents/tab_contents_view_win.h

Issue 146093: Relanding focus manager refactoring (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/tab_contents/tab_contents_view_win.h
===================================================================
--- chrome/browser/views/tab_contents/tab_contents_view_win.h (revision 19153)
+++ chrome/browser/views/tab_contents/tab_contents_view_win.h (working copy)
@@ -26,6 +26,10 @@
explicit TabContentsViewWin(TabContents* tab_contents);
virtual ~TabContentsViewWin();
+ // Reset the native parent of this view to NULL. Unparented windows should
+ // not receive any messages.
+ virtual void Unparent();
Ben Goodger (Google) 2009/06/26 21:18:08 doesn't need to be virtual
+
// TabContentsView implementation --------------------------------------------
virtual void CreateView();
@@ -52,6 +56,9 @@
virtual void TakeFocus(bool reverse);
virtual void HandleKeyboardEvent(const NativeWebKeyboardEvent& event);
+ // WidgetWin overridde.
+ virtual views::FocusManager* GetFocusManager();
+
private:
// Windows events ------------------------------------------------------------
@@ -104,6 +111,10 @@
// The context menu. Callbacks are asynchronous so we need to keep it around.
scoped_ptr<RenderViewContextMenuWin> context_menu_;
+ // The FocusManager associated with this tab. Stored as it is not directly
+ // accessible when unparented.
+ views::FocusManager* focus_manager_;
+
DISALLOW_COPY_AND_ASSIGN(TabContentsViewWin);
};

Powered by Google App Engine
This is Rietveld 408576698