Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 125148: Making FocusManager portable to toolkit_views (Closed)

Created:
11 years, 6 months ago by jcampan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Removed the last Windows specific part out of the focus manager. HWNDs are not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18872

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -449 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_focus_uitest.cc View 2 3 4 5 6 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/first_run_win.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_win.cc View 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container_view_win.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/browser_bubble_win.cc View 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 2 3 4 5 1 chunk +1 line, -36 lines 0 comments Download
M chrome/browser/views/download_started_animation_win.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_win.cc View 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/find_bar_win_browsertest.cc View 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/first_run_bubble.cc View 2 3 4 5 6 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/info_bubble.cc View 2 3 4 5 6 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tab_contents/tab_contents_view_win.cc View 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/dragged_tab_view.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/native_view_photobooth_win.cc View 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/menu/chrome_menu.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M views/controls/native_control.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/native_control_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tabbed_pane.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tree/tree_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -3 lines 0 comments Download
M views/focus/external_focus_tracker.cc View 1 2 3 4 5 6 2 chunks +3 lines, -0 lines 0 comments Download
M views/focus/focus_manager.h View 1 2 3 4 5 6 9 chunks +18 lines, -67 lines 0 comments Download
M views/focus/focus_manager.cc View 1 2 3 4 5 6 9 chunks +13 lines, -211 lines 0 comments Download
A views/focus/focus_manager_gtk.cc View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
A views/focus/focus_manager_win.cc View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M views/view.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M views/view_unittest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M views/view_win.cc View 1 2 3 4 5 6 2 chunks +1 line, -13 lines 0 comments Download
M views/views.gyp View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M views/widget/accelerator_handler.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M views/widget/root_view.cc View 1 2 3 4 5 6 3 chunks +4 lines, -17 lines 0 comments Download
M views/widget/widget.h View 1 2 3 4 5 6 2 chunks +7 lines, -2 lines 0 comments Download
M views/widget/widget_win.h View 1 2 3 4 5 6 5 chunks +11 lines, -6 lines 0 comments Download
M views/widget/widget_win.cc View 1 2 3 4 5 6 7 chunks +27 lines, -14 lines 0 comments Download
M views/window/window_win.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jcampan
11 years, 6 months ago (2009-06-19 17:11:38 UTC) #1
Ben Goodger (Google)
11 years, 6 months ago (2009-06-19 19:42:26 UTC) #2
LG, just a couple of notes...

http://codereview.chromium.org/125148/diff/2055/3173
File views/focus/focus_manager.h (right):

http://codereview.chromium.org/125148/diff/2055/3173#newcode36
Line 36: // |has_own_focus_manager| of the Init method lets you specify whether
that
you might update these comments.

http://codereview.chromium.org/125148/diff/2055/3157
File views/widget/widget_win.cc (right):

http://codereview.chromium.org/125148/diff/2055/3157#newcode431
Line 431: reinterpret_cast<WidgetWin*>(win_util::GetWindowUserData(root));
Why not use your GetWidget() function below, here?

Powered by Google App Engine
This is Rietveld 408576698