Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/external_tab_container.cc

Issue 146093: Relanding focus manager refactoring (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_focus_uitest.cc ('k') | chrome/browser/first_run_win.cc » ('j') | chrome/browser/views/tab_contents/tab_contents_view_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/external_tab_container.cc
===================================================================
--- chrome/browser/external_tab_container.cc (revision 19153)
+++ chrome/browser/external_tab_container.cc (working copy)
@@ -53,11 +53,12 @@
}
set_window_style(WS_POPUP);
- views::WidgetWin::Init(NULL, bounds, true);
+ views::WidgetWin::Init(NULL, bounds);
if (!IsWindow()) {
NOTREACHED();
return false;
}
+ // TODO(jcampan): limit focus traversal to contents.
// We don't ever remove the prop because the lifetime of this object
// is the same as the lifetime of the window
« no previous file with comments | « chrome/browser/browser_focus_uitest.cc ('k') | chrome/browser/first_run_win.cc » ('j') | chrome/browser/views/tab_contents/tab_contents_view_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698