Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 144009: Move socket related files from net/base to net/socket. (Closed)

Created:
11 years, 6 months ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), willchan no longer on Chromium, Ben Goodger (Google)
Visibility:
Public.

Description

Move socket related files from net/base to net/socket. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18985

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -8500 lines) Patch
M chrome/browser/net/url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/base/client_socket.h View 1 chunk +0 lines, -59 lines 0 comments Download
D net/base/client_socket.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D net/base/client_socket_factory.h View 1 chunk +0 lines, -37 lines 0 comments Download
D net/base/client_socket_factory.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D net/base/client_socket_handle.h View 1 chunk +0 lines, -100 lines 0 comments Download
D net/base/client_socket_handle.cc View 1 chunk +0 lines, -73 lines 0 comments Download
D net/base/client_socket_pool.h View 1 chunk +0 lines, -97 lines 0 comments Download
D net/base/socket.h View 1 chunk +0 lines, -44 lines 0 comments Download
D net/base/socket_test_util.h View 1 chunk +0 lines, -204 lines 0 comments Download
D net/base/socket_test_util.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D net/base/ssl_client_socket.h View 1 chunk +0 lines, -34 lines 0 comments Download
D net/base/ssl_client_socket_mac.h View 1 chunk +0 lines, -108 lines 0 comments Download
D net/base/ssl_client_socket_mac.cc View 1 chunk +0 lines, -762 lines 0 comments Download
D net/base/ssl_client_socket_nss.h View 1 chunk +0 lines, -127 lines 0 comments Download
D net/base/ssl_client_socket_nss.cc View 1 chunk +0 lines, -820 lines 0 comments Download
D net/base/ssl_client_socket_unittest.cc View 1 chunk +0 lines, -370 lines 0 comments Download
D net/base/ssl_client_socket_win.h View 1 chunk +0 lines, -157 lines 0 comments Download
D net/base/ssl_client_socket_win.cc View 1 chunk +0 lines, -1190 lines 0 comments Download
D net/base/ssl_test_util.h View 1 chunk +0 lines, -115 lines 0 comments Download
D net/base/ssl_test_util.cc View 1 chunk +0 lines, -366 lines 0 comments Download
D net/base/tcp_client_socket.h View 1 chunk +0 lines, -27 lines 0 comments Download
D net/base/tcp_client_socket_libevent.h View 1 chunk +0 lines, -135 lines 0 comments Download
D net/base/tcp_client_socket_libevent.cc View 1 chunk +0 lines, -373 lines 0 comments Download
D net/base/tcp_client_socket_pool.h View 1 chunk +0 lines, -340 lines 0 comments Download
D net/base/tcp_client_socket_pool.cc View 1 chunk +0 lines, -555 lines 0 comments Download
D net/base/tcp_client_socket_pool_unittest.cc View 1 chunk +0 lines, -588 lines 0 comments Download
D net/base/tcp_client_socket_unittest.cc View 1 chunk +0 lines, -339 lines 0 comments Download
D net/base/tcp_client_socket_win.h View 1 chunk +0 lines, -77 lines 0 comments Download
D net/base/tcp_client_socket_win.cc View 1 chunk +0 lines, -578 lines 0 comments Download
D net/base/tcp_pinger.h View 1 chunk +0 lines, -132 lines 0 comments Download
D net/base/tcp_pinger_unittest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M net/ftp/ftp_network_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_basic_stream.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_session.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_network_transaction.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/net.gyp View 1 8 chunks +30 lines, -29 lines 0 comments Download
A + net/socket/client_socket.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/client_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/client_socket_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/socket/client_socket_factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + net/socket/client_socket_handle.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/client_socket_handle.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + net/socket/client_socket_pool.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/socket/socket.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/socket/socket_test_util.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/socket_test_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + net/socket/ssl_client_socket.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/ssl_client_socket_mac.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/ssl_client_socket_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/ssl_client_socket_nss.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/ssl_client_socket_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/ssl_client_socket_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
A + net/socket/ssl_client_socket_win.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/ssl_client_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/ssl_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/socket/ssl_test_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/socket/tcp_client_socket.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + net/socket/tcp_client_socket_libevent.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/tcp_client_socket_libevent.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/tcp_client_socket_pool.h View 5 chunks +6 lines, -6 lines 0 comments Download
A + net/socket/tcp_client_socket_pool.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + net/socket/tcp_client_socket_pool_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + net/socket/tcp_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/tcp_client_socket_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + net/socket/tcp_client_socket_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + net/socket/tcp_pinger.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + net/socket/tcp_pinger_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell_main.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
willchan no longer on Chromium
I think I'll have to merge eroman's change to net.gyp. Note that I didn't pull ...
11 years, 6 months ago (2009-06-22 22:18:11 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/144009/diff/1/71 File net/ftp/ftp_network_transaction_unittest.cc (right): http://codereview.chromium.org/144009/diff/1/71#newcode12 Line 12: #include "net/socket/socket_test_util.h" nit: ftp before socket
11 years, 6 months ago (2009-06-22 22:23:47 UTC) #2
willchan no longer on Chromium
FYI: I had to also add webkit/DEPS to account for the move in one of ...
11 years, 6 months ago (2009-06-22 22:39:45 UTC) #3
eroman
11 years, 6 months ago (2009-06-22 23:37:26 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698