Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 118530: Fix the ALL_CAPS black list regexp. (Closed)

Created:
11 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
Jói Sigurðsson
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix the ALL_CAPS black list regexp. Add some regexp unit test. TEST=unit test BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18139

Patch Set 1 #

Patch Set 2 : indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -6 lines) Patch
M presubmit_support.py View 3 chunks +8 lines, -5 lines 0 comments Download
M tests/presubmit_unittest.py View 1 2 chunks +73 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 6 months ago (2009-06-10 21:09:21 UTC) #1
Jói Sigurðsson
11 years, 6 months ago (2009-06-11 01:50:05 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698