Fix the ALL_CAPS black list regexp.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 import exceptions
 import random
 import string
@@ skipping 95 matching lines @@
 class PresubmitUnittest(PresubmitTestsBase):
   """General presubmit_support.py tests (excluding InputApi and OutputApi)."""
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'AffectedFile', 'DoPresubmitChecks', 'GclChange', 'InputApi',
       'ListRelevantPresubmitFiles', 'Main', 'NotImplementedException',
       'OutputApi', 'ParseFiles', 'PresubmitExecuter',
       'ScanSubDirs', 'SvnAffectedFile',
       'cPickle', 'cStringIO', 'exceptions',
-      'fnmatch', 'gcl', 'gclient', 'glob', 'marshal', 'normpath', 'optparse',
+      'fnmatch', 'gcl', 'gclient', 'glob', 'logging', 'marshal', 'normpath',
+      'optparse',
       'os', 'pickle', 'presubmit_canned_checks', 're', 'subprocess', 'sys',
       'tempfile', 'traceback', 'types', 'unittest', 'urllib2', 'warnings',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit, members)
 
   def testListRelevantPresubmitFiles(self):
     join = presubmit.os.path.join
     files = [
       'blat.cc',
@@ skipping 513 matching lines @@
     # Ignores weird because of whitelist, third_party because of blacklist,
     # binary isn't a text file and beingdeleted doesn't exist. The rest is
     # outside foo/.
     rhs_lines = [x for x in input_api.RightHandSideLines(None)]
     self.assertEquals(len(rhs_lines), 4)
     self.assertEqual(rhs_lines[0][0].LocalPath(), presubmit.normpath(blat))
     self.assertEqual(rhs_lines[1][0].LocalPath(), presubmit.normpath(blat))
     self.assertEqual(rhs_lines[2][0].LocalPath(), presubmit.normpath(another))
     self.assertEqual(rhs_lines[3][0].LocalPath(), presubmit.normpath(another))
 
+  def testDefaultWhiteListBlackListFilters(self):
+    def f(x):
+      return presubmit.AffectedFile(x, 'M')
+    files = [
+      (
+        [
+          # To be tested.
+          f('a/experimental/b'),
+          f('experimental/b'),
+          f('a/experimental'),
+          f('a/experimental.cc'),
+        ],
+        [
+          # Expected.
+          'a/experimental',
+          'a/experimental.cc',
+        ],
+      ),
+      (
+        [
+          # To be tested.
+          f('a/third_party/b'),
+          f('third_party/b'),
+          f('a/third_party'),
+          f('a/third_party.cc'),
+        ],
+        [
+          # Expected.
+          'a/third_party',
+          'a/third_party.cc',
+        ],
+      ),
+      (
+        [
+          # To be tested.
+          f('a/LOL_FILE/b'),
+          f('b.c/LOL_FILE'),
+          f('a/PRESUBMIT.py'),
+        ],
+        [
+          # Expected.
+          'a/LOL_FILE/b',
+          'a/PRESUBMIT.py',
+        ],
+      ),
+      (
+        [
+          # To be tested.
+          f('a/.git'),
+          f('b.c/.git'),
+          f('a/.git/bleh.py'),
+          f('.git/bleh.py'),
+        ],
+        [
+          # Expected.
+          'b.c/.git',
+        ],
+      ),
+    ]
+    input_api = presubmit.InputApi(None, './PRESUBMIT.py', False)
+    self.mox.ReplayAll()
+
+    self.assertEqual(len(input_api.DEFAULT_BLACK_LIST), 9)
+    for item in files:
+      results = filter(input_api.FilterSourceFile, item[0])
+      for i in range(len(results)):
+        self.assertEquals(results[i].LocalPath(),
+                          presubmit.normpath(item[1][i]))
+      # Same number of expected results.
+      self.assertEquals(len(results), len(item[1]))
+
   def testCustomFilter(self):
     def FilterSourceFile(affected_file):
       return 'a' in affected_file.LocalPath()
     files = [('A', 'eeaee'), ('M', 'eeabee'), ('M', 'eebcee')]
     for (action, item) in files:
       presubmit.os.path.exists(item).AndReturn(True)
       presubmit.os.path.isdir(item).AndReturn(False)
       presubmit.gcl.GetSVNFileProperty(item, 'svn:mime-type').AndReturn(None)
     self.mox.ReplayAll()
 
@@ skipping 647 matching lines @@
     test_result.errors = 0
     self.mox.ReplayAll()
 
     results = presubmit_canned_checks.RunPythonUnitTests(
         input_api, presubmit.OutputApi, ['test_module'])
     self.assertEquals(len(results), 0)
 
 
 if __name__ == '__main__':
   unittest.main()