Fix the ALL_CAPS black list regexp.

presubmit_support.py

Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index 58129c1e4ac4dd7293be1301ff57f0b41870b8b1..7d6eee4ac75e7b34fe96521ec117262a3f5b9b2b 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -17,6 +17,7 @@ import cStringIO  # Exposed through the API.
 import exceptions
 import fnmatch
 import glob
+import logging
 import marshal  # Exposed through the API.
 import optparse
 import os  # Somewhat exposed through the API.
@@ -162,10 +163,10 @@ class InputApi(object):
       r".*\bxcodebuild[\\\/].*",
       r".*\bsconsbuild[\\\/].*",
       # All caps files like README and LICENCE.
-      r".*\b[A-Z0-9_]+",
-      # SCM (can happen in dual SCM configuration)
-      r".*\b\.git[\\\/].*",
-      r".*\b\.svn[\\\/].*",
+      r".*\b[A-Z0-9_]+$",
+      # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
+      r".*\.git[\\\/].*",
+      r".*\.svn[\\\/].*",
   )
 
   def __init__(self, change, presubmit_path, is_committing):
@@ -294,7 +295,9 @@ class InputApi(object):
     """
     def Find(affected_file, list):
       for item in list:
-        if self.re.match(item, affected_file.LocalPath()):
+        local_path = affected_file.LocalPath()
+        if self.re.match(item, local_path):
+          logging.debug("%s matched %s" % (item, local_path))
           return True
       return False
     return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and