Fix the ALL_CAPS black list regexp.

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.2'
 
 # TODO(joi) Add caching where appropriate/needed. The API is designed to allow
 # caching (between all different invocations of presubmit scripts for a given
 # change). We should add it as our presubmit scripts start feeling slow.
 
 import cPickle  # Exposed through the API.
 import cStringIO  # Exposed through the API.
 import exceptions
 import fnmatch
 import glob
+import logging
 import marshal  # Exposed through the API.
 import optparse
 import os  # Somewhat exposed through the API.
 import pickle  # Exposed through the API.
 import re  # Exposed through the API.
 import subprocess  # Exposed through the API.
 import sys  # Parts exposed through API.
 import tempfile  # Exposed through the API.
 import traceback  # Exposed through the API.
 import types
@@ skipping 125 matching lines @@
   # files. Don't modify this list from a presubmit script!
   DEFAULT_BLACK_LIST = (
       r".*\bexperimental[\\\/].*",
       r".*\bthird_party[\\\/].*",
       # Output directories (just in case)
       r".*\bDebug[\\\/].*",
       r".*\bRelease[\\\/].*",
       r".*\bxcodebuild[\\\/].*",
       r".*\bsconsbuild[\\\/].*",
       # All caps files like README and LICENCE.
-      r".*\b[A-Z0-9_]+",
-      # SCM (can happen in dual SCM configuration)
-      r".*\b\.git[\\\/].*",
-      r".*\b\.svn[\\\/].*",
+      r".*\b[A-Z0-9_]+$",
+      # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
+      r".*\.git[\\\/].*",
+      r".*\.svn[\\\/].*",
   )
 
   def __init__(self, change, presubmit_path, is_committing):
     """Builds an InputApi object.
 
     Args:
       change: A presubmit.GclChange object.
       presubmit_path: The path to the presubmit script being processed.
       is_committing: True if the change is about to be committed.
     """
@@ skipping 108 matching lines @@
     If white_list or black_list is None, InputApi.DEFAULT_WHITE_LIST
     and InputApi.DEFAULT_BLACK_LIST is used respectively.
 
     The lists will be compiled as regular expression and
     AffectedFile.LocalPath() needs to pass both list.
 
     Note: Copy-paste this function to suit your needs or use a lambda function.
     """
     def Find(affected_file, list):
       for item in list:
-        if self.re.match(item, affected_file.LocalPath()):
+        local_path = affected_file.LocalPath()
+        if self.re.match(item, local_path):
+          logging.debug("%s matched %s" % (item, local_path))
           return True
       return False
     return (Find(affected_file, white_list or self.DEFAULT_WHITE_LIST) and
             not Find(affected_file, black_list or self.DEFAULT_BLACK_LIST))
 
   def AffectedSourceFiles(self, source_file):
     """Filter the list of AffectedTextFiles by the function source_file.
 
     If source_file is None, InputApi.FilterSourceFile() is used.
     """
@@ skipping 503 matching lines @@
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                None,
                                False)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))