Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 11568: Move skia extensions from the port to skia/ext. (Closed)

Created:
12 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Move skia extensions from the port to skia/ext for Windows only. Fixed the include guards of the moved files, but nothing else.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -2442 lines) Patch
M base/gfx/bitmap_platform_device_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/platform_canvas_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/platform_device_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/gfx/vector_device.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 1 1 chunk +0 lines, -1 line 0 comments Download
M skia/SConscript View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
A + skia/ext/bitmap_platform_device_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + skia/ext/bitmap_platform_device_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + skia/ext/platform_canvas_win.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + skia/ext/platform_canvas_win.cc View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
A + skia/ext/platform_device_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + skia/ext/platform_device_win.cc View 1 chunk +1 line, -1 line 0 comments Download
A + skia/ext/vector_canvas_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + skia/ext/vector_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.vcproj View 1 1 chunk +56 lines, -0 lines 0 comments Download
M webkit/SConscript.port View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/build/port/port.vcproj View 1 1 chunk +0 lines, -60 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/BitmapPlatformDevice.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceWin.h View 1 1 chunk +0 lines, -111 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/BitmapPlatformDeviceWin.cpp View 1 1 chunk +0 lines, -446 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/PlatformCanvas.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformCanvasWin.h View 1 1 chunk +0 lines, -202 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformCanvasWin.cpp View 1 1 chunk +0 lines, -118 lines 0 comments Download
M webkit/port/platform/graphics/skia/public/PlatformDevice.h View 1 1 chunk +1 line, -1 line 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformDeviceWin.h View 1 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/PlatformDeviceWin.cpp View 1 1 chunk +0 lines, -229 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/VectorCanvas.h View 1 1 chunk +0 lines, -46 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/VectorCanvas.cpp View 1 1 chunk +0 lines, -90 lines 0 comments Download
D webkit/port/platform/graphics/skia/public/VectorCanvas_unittest.cpp View 1 1 chunk +0 lines, -1009 lines 0 comments Download
M webkit/tools/test_shell/test_shell_tests.vcproj View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brettw
This still leaves a trail of headers all over the place. (base/gfx, and port/...) which ...
12 years, 1 month ago (2008-11-21 21:04:32 UTC) #1
Peter Kasting
Rubber-stamp LGTM with nit. http://codereview.chromium.org/11568/diff/106/300 File chrome/chrome.sln (left): http://codereview.chromium.org/11568/diff/106/300#oldcode576 Line 576: {5597AD47-3494-4750-A235-4F9C2F864700} = {5597AD47-3494-4750-A235-4F9C2F864700} Did ...
12 years, 1 month ago (2008-11-21 21:13:03 UTC) #2
Peter Kasting
Brett, did you ever check this in? It shows as still open.
12 years ago (2008-12-01 23:05:44 UTC) #3
Peter Kasting
11 years, 10 months ago (2009-01-30 21:53:26 UTC) #4
Ping, what happened with this?

Powered by Google App Engine
This is Rietveld 408576698