Issue 115474: Rename official builds to "Google Chrome" on disk and "Chrome" in the menubar...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115474: Rename official builds to "Google Chrome" on disk and "Chrome" in the menubar... (Closed)

Created:
11 years, 7 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Rename official builds to "Google Chrome" on disk and "Chrome" in the menubar. BUG=11826 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16313

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -21 lines)			Patch
M	build/mac/build_app_dmg	View	1 chunk	+12 lines, -3 lines	0 comments	Download
M	build/mac/dump_app_syms	View	1 chunk	+8 lines, -1 line	1 comment	Download
M	build/mac/tweak_app_infoplist	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/app/app-Info.plist	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	4 chunks	+21 lines, -12 lines	0 comments	Download
M	chrome/common/mac_app_names.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/tools/build/mac/FILES-official	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG http://codereview.chromium.org/115474/diff/1/3 File build/mac/build_app_dmg (right): http://codereview.chromium.org/115474/diff/1/3#newcode38 Line 38: DST_DMG_PATH="${BUILT_PRODUCTS_DIR}/${DMG_NAME}" Maybe you can just do "${BUILT_PRODUCTS_DIR}/$(echo ...

11 years, 7 months ago (2009-05-18 20:26:29 UTC) #2

TVL

cl updated, i missed a script i'm gonna keep dmg name for now, i'd like ...

11 years, 7 months ago (2009-05-18 20:30:18 UTC) #3