Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: build/mac/build_app_dmg

Issue 115474: Rename official builds to "Google Chrome" on disk and "Chrome" in the menubar... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/mac/dump_app_syms » ('j') | build/mac/dump_app_syms » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/mac/build_app_dmg
===================================================================
--- build/mac/build_app_dmg (revision 16299)
+++ build/mac/build_app_dmg (working copy)
@@ -21,11 +21,20 @@
TOP="${SRCROOT}/.."
PKG_DMG="${TOP}/build/mac/pkg-dmg"
-APP_NAME=$1
+BUILD_BRANDING=$1
+if [ "${BUILD_BRANDING}" == "Chromium" ]; then
+ APP_NAME="Chromium"
+ DMG_NAME="Chromium.dmg"
+elif [ "${BUILD_BRANDING}" == "Chrome" ]; then
+ APP_NAME="Google Chrome"
+ DMG_NAME="GoogleChrome.dmg"
+else
+ echo "error: unknown branding: ${BUILD_BRANDING}" >&2
+ exit 1
+fi
+
SRC_APP_PATH="${BUILT_PRODUCTS_DIR}/${APP_NAME}.app"
VOL_NAME="${APP_NAME}"
-# Do we want a svn version in the DMG name?
-DMG_NAME="${APP_NAME}.dmg"
DST_DMG_PATH="${BUILT_PRODUCTS_DIR}/${DMG_NAME}"
# show things as we run them
« no previous file with comments | « no previous file | build/mac/dump_app_syms » ('j') | build/mac/dump_app_syms » ('J')

Powered by Google App Engine
This is Rietveld 408576698