Issue 113991: Make Combobox portable

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+800 lines, -449 lines)			Patch
M	chrome/browser/views/bookmark_bubble_view.h	View	1 2 3 4 5 6	5 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/views/bookmark_bubble_view.cc	View	1 2 3 4 5 6	5 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/views/bug_report_view.h	View	1 2 3 4 5 6	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/bug_report_view.cc	View	1 2 3 4 5 6	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/views/clear_browsing_data.h	View	1 2 3 4 5 6	4 chunks	+11 lines, -11 lines	0 comments	Download
M	chrome/browser/views/clear_browsing_data.cc	View	1 2 3 4 5 6	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/views/first_run_customize_view.h	View	1 2 3 4 5 6	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/views/first_run_customize_view.cc	View	1 2 3 4 5 6	4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/views/importer_view.h	View	1 2 3 4 5 6	4 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/views/importer_view.cc	View	1 2 3 4 5 6	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/views/options/advanced_contents_view.cc	View	1 2 3 4 5 6	13 chunks	+21 lines, -21 lines	0 comments	Download
M	chrome/browser/views/options/fonts_page_view.h	View	1 2 3 4 5 6	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/options/fonts_page_view.cc	View	1 2 3 4 5 6	5 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/views/options/general_page_view.h	View	1 2 3 4 5 6	4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/options/general_page_view.cc	View	1 2 3 4 5 6	9 chunks	+30 lines, -30 lines	0 comments	Download
M	chrome/browser/views/options/language_combobox_model.h	View	1 2 3 4 5 6	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/views/options/language_combobox_model.cc	View	1 2 3 4 5 6	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/options/languages_page_view.h	View	1 2 3 4 5 6	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/views/options/languages_page_view.cc	View	1 2 3 4 5 6	9 chunks	+12 lines, -13 lines	0 comments	Download
M	chrome/browser/views/select_profile_dialog.h	View	1 2 3 4 5 6	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/views/select_profile_dialog.cc	View	1 2 3 4 5 6	4 chunks	+4 lines, -5 lines	0 comments	Download
D	views/controls/combo_box.h	View	1 2 3 4 5 6	1 chunk	+0 lines, -80 lines	0 comments	Download
D	views/controls/combo_box.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -179 lines	0 comments	Download
A	views/controls/combobox/combobox.h	View	1 2 3 4 5 6	1 chunk	+89 lines, -0 lines	0 comments	Download
A	views/controls/combobox/combobox.cc	View	1 2 3 4 5 6	1 chunk	+104 lines, -0 lines	0 comments	Download
A	views/controls/combobox/native_combobox_gtk.h	View		1 chunk	+43 lines, -0 lines	0 comments	Download
A	views/controls/combobox/native_combobox_gtk.cc	View		1 chunk	+78 lines, -0 lines	0 comments	Download
A	views/controls/combobox/native_combobox_win.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
A	views/controls/combobox/native_combobox_win.cc	View	1 2	1 chunk	+184 lines, -0 lines	0 comments	Download
A	views/controls/combobox/native_combobox_wrapper.h	View		1 chunk	+48 lines, -0 lines	0 comments	Download
M	views/controls/native/native_view_host_win.cc	View	3 4 5 6	2 chunks	+4 lines, -0 lines	0 comments	Download
M	views/controls/native_control_win.h	View	1 2 3 4 5 6	1 chunk	+3 lines, -3 lines	0 comments	Download
M	views/controls/native_control_win.cc	View	3 4 5 6	2 chunks	+12 lines, -6 lines	0 comments	Download
M	views/views.gyp	View	1 2 3 4 5 6	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

11 years, 6 months ago (2009-06-01 16:47:17 UTC) #2

LGTM

http://codereview.chromium.org/113991/diff/58/1106
File views/controls/native_control_win.cc (right):

http://codereview.chromium.org/113991/diff/58/1106#newcode128
Line 128: SetProp(native_control, kNativeControlOriginalWndProcKey,
original_wndproc_);
Line too long.

Expand Messages | Collapse Messages