Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/views/bug_report_view.cc

Issue 113991: Make Combobox portable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/bug_report_view.h ('k') | chrome/browser/views/clear_browsing_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/bug_report_view.cc
===================================================================
--- chrome/browser/views/bug_report_view.cc (revision 17310)
+++ chrome/browser/views/bug_report_view.cc (working copy)
@@ -45,7 +45,7 @@
static const char kReportPhishingUrl[] =
"http://www.google.com/safebrowsing/report_phish/";
-class BugReportComboBoxModel : public views::ComboBox::Model {
+class BugReportComboBoxModel : public views::Combobox::Model {
public:
BugReportComboBoxModel() {}
@@ -60,12 +60,12 @@
OTHER_PROBLEM
};
- // views::ComboBox::Model interface.
- virtual int GetItemCount(views::ComboBox* source) {
+ // views::Combobox::Model interface.
+ virtual int GetItemCount(views::Combobox* source) {
return OTHER_PROBLEM + 1;
}
- virtual std::wstring GetItemAt(views::ComboBox* source, int index) {
+ virtual std::wstring GetItemAt(views::Combobox* source, int index) {
return GetItemAtIndex(index);
}
@@ -191,8 +191,8 @@
// Adds all controls.
bug_type_label_ = new views::Label(
l10n_util::GetString(IDS_BUGREPORT_BUG_TYPE));
- bug_type_combo_ = new views::ComboBox(bug_type_model_.get());
- bug_type_combo_->SetListener(this);
+ bug_type_combo_ = new views::Combobox(bug_type_model_.get());
+ bug_type_combo_->set_listener(this);
page_title_label_ = new views::Label(
l10n_util::GetString(IDS_BUGREPORT_REPORT_PAGE_TITLE));
@@ -272,7 +272,7 @@
IDS_BUGREPORT_DIALOG_HEIGHT_LINES));
}
-void BugReportView::ItemChanged(views::ComboBox* combo_box,
+void BugReportView::ItemChanged(views::Combobox* combobox,
int prev_index,
int new_index) {
if (new_index == prev_index)
« no previous file with comments | « chrome/browser/views/bug_report_view.h ('k') | chrome/browser/views/clear_browsing_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698