Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3333)

Unified Diff: chrome/browser/views/importer_view.cc

Issue 113991: Make Combobox portable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/importer_view.h ('k') | chrome/browser/views/options/advanced_contents_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/importer_view.cc
===================================================================
--- chrome/browser/views/importer_view.cc (revision 17310)
+++ chrome/browser/views/importer_view.cc (working copy)
@@ -51,8 +51,8 @@
import_from_label_ =
new views::Label(l10n_util::GetString(IDS_IMPORT_FROM_LABEL));
- profile_combobox_ = new views::ComboBox(this);
- profile_combobox_->SetListener(this);
+ profile_combobox_ = new views::Combobox(this);
+ profile_combobox_->set_listener(this);
import_items_label_ =
new views::Label(l10n_util::GetString(IDS_IMPORT_ITEMS_LABEL));
@@ -135,7 +135,7 @@
uint16 items = GetCheckedItems();
Browser* browser = BrowserList::GetLastActive();
- int selected_index = profile_combobox_->GetSelectedItem();
+ int selected_index = profile_combobox_->selected_item();
HWND parent_hwnd =
reinterpret_cast<HWND>(browser->window()->GetNativeHandle());
StartImportingWithUI(parent_hwnd, items, importer_host_.get(),
@@ -151,7 +151,7 @@
return this;
}
-int ImporterView::GetItemCount(views::ComboBox* source) {
+int ImporterView::GetItemCount(views::Combobox* source) {
DCHECK(source == profile_combobox_);
DCHECK(importer_host_.get());
int item_count = importer_host_->GetAvailableProfileCount();
@@ -160,15 +160,15 @@
return item_count;
}
-std::wstring ImporterView::GetItemAt(views::ComboBox* source, int index) {
+std::wstring ImporterView::GetItemAt(views::Combobox* source, int index) {
DCHECK(source == profile_combobox_);
DCHECK(importer_host_.get());
return importer_host_->GetSourceProfileNameAt(index);
}
-void ImporterView::ItemChanged(views::ComboBox* combo_box,
+void ImporterView::ItemChanged(views::Combobox* combobox,
int prev_index, int new_index) {
- DCHECK(combo_box);
+ DCHECK(combobox);
DCHECK(checkbox_items_.size() >=
static_cast<size_t>(importer_host_->GetAvailableProfileCount()));
« no previous file with comments | « chrome/browser/views/importer_view.h ('k') | chrome/browser/views/options/advanced_contents_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698