Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1139)

Unified Diff: chrome/browser/views/clear_browsing_data.cc

Issue 113991: Make Combobox portable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/clear_browsing_data.h ('k') | chrome/browser/views/first_run_customize_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/clear_browsing_data.cc
===================================================================
--- chrome/browser/views/clear_browsing_data.cc (revision 17310)
+++ chrome/browser/views/clear_browsing_data.cc (working copy)
@@ -113,10 +113,10 @@
AddChildView(time_period_label_);
// Add the combo box showing how far back in time we want to delete.
- time_period_combobox_ = new views::ComboBox(this);
+ time_period_combobox_ = new views::Combobox(this);
time_period_combobox_->SetSelectedItem(profile_->GetPrefs()->GetInteger(
prefs::kDeleteTimePeriod));
- time_period_combobox_->SetListener(this);
+ time_period_combobox_->set_listener(this);
AddChildView(time_period_combobox_);
}
@@ -311,14 +311,14 @@
}
////////////////////////////////////////////////////////////////////////////////
-// ClearBrowsingDataView, views::ComboBox::Model implementation:
+// ClearBrowsingDataView, views::Combobox::Model implementation:
-int ClearBrowsingDataView::GetItemCount(views::ComboBox* source) {
+int ClearBrowsingDataView::GetItemCount(views::Combobox* source) {
DCHECK(source == time_period_combobox_);
return 4;
}
-std::wstring ClearBrowsingDataView::GetItemAt(views::ComboBox* source,
+std::wstring ClearBrowsingDataView::GetItemAt(views::Combobox* source,
int index) {
DCHECK(source == time_period_combobox_);
switch (index) {
@@ -334,7 +334,7 @@
////////////////////////////////////////////////////////////////////////////////
// ClearBrowsingDataView, views::ComboBoxListener implementation:
-void ClearBrowsingDataView::ItemChanged(views::ComboBox* sender,
+void ClearBrowsingDataView::ItemChanged(views::Combobox* sender,
int prev_index, int new_index) {
if (sender == time_period_combobox_ && prev_index != new_index)
profile_->GetPrefs()->SetInteger(prefs::kDeleteTimePeriod, new_index);
@@ -409,7 +409,7 @@
}
void ClearBrowsingDataView::OnDelete() {
- int period_selected = time_period_combobox_->GetSelectedItem();
+ int period_selected = time_period_combobox_->selected_item();
int remove_mask = 0;
if (IsCheckBoxEnabledAndSelected(del_history_checkbox_))
« no previous file with comments | « chrome/browser/views/clear_browsing_data.h ('k') | chrome/browser/views/first_run_customize_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698