Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11360207: Add Java resources to content and chrome. (Closed)

Created:
8 years, 1 month ago by newt (away)
Modified:
8 years, 1 month ago
CC:
chromium-reviews, jam, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Add Java resources to content and chrome. This adds Java resources directly to the content and chrome folders and starts accessing them through the Java classes org.chromium.content.R and org.chromium.chrome.R instead of using AppResource. A following CL will remove these resources from ContentShell and other build targets that currently provide duplicates of these resources. The following CL will also remove remaining references to AppResource. This is the second of three CLs to replace AppResource with R: 1. http://codereview.chromium.org/11363150 - Support Java resources within content 2. http://codereview.chromium.org/11360207 - Add Java resources to content and chrome 3. http://codereview.chromium.org/11377117 - Remove AppResource and unneeded resources BUG=136704 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168759

Patch Set 1 #

Patch Set 2 : move chrome resources into chrome #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Total comments: 7

Patch Set 5 : fix nits and rebase #

Patch Set 6 : rebase and remove binary files #

Patch Set 7 : remove obsolete findbugs warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -217 lines) Patch
M build/android/findbugs_filter/findbugs_known_bugs.txt View 1 2 3 4 5 6 2 chunks +0 lines, -51 lines 0 comments Download
A + chrome/android/java/res/layout/autofill_text.xml View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
A chrome/android/java/res/layout/js_modal_dialog.xml View 1 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/android/java/res/values-sw600dp/dimens.xml View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A chrome/android/java/res/values-sw800dp/dimens.xml View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A + chrome/android/java/res/values/colors.xml View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A chrome/android/java/res/values/dimens.xml View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/strings.xml View 1 2 1 chunk +26 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/BookmarkUtils.java View 1 4 chunks +12 lines, -30 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderSuggestionsCursor.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/JavascriptAppModalDialog.java View 1 7 chunks +18 lines, -40 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillListAdapter.java View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A content/public/android/java/res/layout-land/date_time_picker_dialog.xml View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A content/public/android/java/res/layout/date_time_picker_dialog.xml View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A content/public/android/java/res/layout/month_picker.xml View 1 chunk +48 lines, -0 lines 0 comments Download
A content/public/android/java/res/layout/month_picker_dialog.xml View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
A + content/public/android/java/res/values/dimens.xml View 1 chunk +2 lines, -3 lines 0 comments Download
A content/public/android/java/res/values/official-command-line.xml View 1 chunk +14 lines, -0 lines 0 comments Download
M content/public/android/java/res/values/strings.xml View 1 2 1 chunk +42 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/AndroidBrowserProcess.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 4 3 chunks +3 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DateTimePickerDialog.java View 1 2 2 chunks +6 lines, -12 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/InputDialogContainer.java View 3 chunks +3 lines, -6 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MonthPicker.java View 4 chunks +5 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MonthPickerDialog.java View 1 2 2 chunks +5 lines, -10 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/PopupZoomer.java View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java View 1 3 chunks +6 lines, -12 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/SelectFileDialog.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
newt (away)
PTAL, thanks!
8 years, 1 month ago (2012-11-13 00:13:50 UTC) #1
newt (away)
Primary reviewers: +benm +cjhopman Secondary reviewer: +nileshagrawal Thanks!
8 years, 1 month ago (2012-11-15 00:59:02 UTC) #2
benm (inactive)
http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml File chrome/android/java/res/values/strings.xml (right): http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml#newcode11 chrome/android/java/res/values/strings.xml:11: <string name="leave_this_page">Leave this Page</string> Just so I understand, these ...
8 years, 1 month ago (2012-11-15 15:33:13 UTC) #3
newt (away)
http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml File chrome/android/java/res/values/strings.xml (right): http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml#newcode11 chrome/android/java/res/values/strings.xml:11: <string name="leave_this_page">Leave this Page</string> On 2012/11/15 15:33:14, benm wrote: ...
8 years, 1 month ago (2012-11-15 17:04:35 UTC) #4
benm (inactive)
http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml File chrome/android/java/res/values/strings.xml (right): http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml#newcode11 chrome/android/java/res/values/strings.xml:11: <string name="leave_this_page">Leave this Page</string> I see, so the translations ...
8 years, 1 month ago (2012-11-15 17:20:54 UTC) #5
newt (away)
On 2012/11/15 17:20:54, benm wrote: > http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml > File chrome/android/java/res/values/strings.xml (right): > > http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml#newcode11 > ...
8 years, 1 month ago (2012-11-15 17:26:53 UTC) #6
benm (inactive)
lgtm http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml File chrome/android/java/res/values/strings.xml (right): http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/strings.xml#newcode11 chrome/android/java/res/values/strings.xml:11: <string name="leave_this_page">Leave this Page</string> sgtm!
8 years, 1 month ago (2012-11-15 17:44:01 UTC) #7
cjhopman
lgtm
8 years, 1 month ago (2012-11-15 19:03:44 UTC) #8
nilesh
LGTM with nits. http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/layout/autofill_text.xml File chrome/android/java/res/layout/autofill_text.xml (right): http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/layout/autofill_text.xml#newcode29 chrome/android/java/res/layout/autofill_text.xml:29: remove extra line. http://codereview.chromium.org/11360207/diff/14004/chrome/android/java/res/values/colors.xml File chrome/android/java/res/values/colors.xml ...
8 years, 1 month ago (2012-11-19 18:16:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11360207/16004
8 years, 1 month ago (2012-11-19 20:26:51 UTC) #10
commit-bot: I haz the power
Can't process patch for file content/public/android/java/res/drawable/ic_menu_search_holo_light.png. Binary file support is temporarilly disabled due to a ...
8 years, 1 month ago (2012-11-19 20:26:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11360207/25003
8 years, 1 month ago (2012-11-20 04:37:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/newt@chromium.org/11360207/26004
8 years, 1 month ago (2012-11-20 05:24:15 UTC) #13
commit-bot: I haz the power
8 years, 1 month ago (2012-11-20 08:26:30 UTC) #14 
Change committed as 168759

Powered by Google App Engine
This is Rietveld 408576698