Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: ui/android/java/src/org/chromium/ui/SelectFileDialog.java

Issue 11360207: Add Java resources to content and chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove obsolete findbugs warnings Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/SelectFileDialog.java
diff --git a/ui/android/java/src/org/chromium/ui/SelectFileDialog.java b/ui/android/java/src/org/chromium/ui/SelectFileDialog.java
index c9115bf9b9dda9d80eab6833c49bf1bb82ba974e..23319cb1b83a39df688c86c4ee3ab0976561df36 100644
--- a/ui/android/java/src/org/chromium/ui/SelectFileDialog.java
+++ b/ui/android/java/src/org/chromium/ui/SelectFileDialog.java
@@ -27,8 +27,8 @@ import org.chromium.ui.gfx.NativeWindow;
*/
@JNINamespace("ui")
class SelectFileDialog implements NativeWindow.IntentCallback{
- // TODO (aurimas): Swap these constants with AppResources when it gets moved to base to support
- // internationalization.
+ // TODO (aurimas): Move these constants into strings.xml within ui (after crbug.com/136704 is
+ // fixed) to support internationalization.
private static final String LOW_MEMORY_ERROR =
"Unable to complete previous operation due to low memory";
private static final String OPENING_FILE_ERROR = "Failed to open selected file";
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698