| OLD | NEW |
|---|
| 1 H B ES: Comparison of String parameter using == or != in org.chromium.android_we
bview.test.AwSettingsTest$AwSettingsUserAgentStringTestHelper.doEnsureSettingHas
Value(String) At AwSettingsTest.java | 1 H B ES: Comparison of String parameter using == or != in org.chromium.android_we
bview.test.AwSettingsTest$AwSettingsUserAgentStringTestHelper.doEnsureSettingHas
Value(String) At AwSettingsTest.java |
| 2 H B Nm: The class name org.chromium.content.browser.test.util.TouchUtils shadows
the simple name of the superclass android.test.TouchUtils At TouchUtils.java | 2 H B Nm: The class name org.chromium.content.browser.test.util.TouchUtils shadows
the simple name of the superclass android.test.TouchUtils At TouchUtils.java |
| 3 H C EC: Using pointer equality to compare a JavaBridgeCoercionTest$CustomType wi
th a JavaBridgeCoercionTest$CustomType2 in org.chromium.content.browser.JavaBrid
geCoercionTest.testPassJavaObject() At JavaBridgeCoercionTest.java | 3 H C EC: Using pointer equality to compare a JavaBridgeCoercionTest$CustomType wi
th a JavaBridgeCoercionTest$CustomType2 in org.chromium.content.browser.JavaBrid
geCoercionTest.testPassJavaObject() At JavaBridgeCoercionTest.java |
| 4 H D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessCon
nection.mConnectionParams, which is known to be non-null in org.chromium.content
.browser.SandboxedProcessConnection.doConnectionSetup() Redundant null check at
SandboxedProcessConnection.java | 4 H D RCN: Redundant nullcheck of org.chromium.content.browser.SandboxedProcessCon
nection.mConnectionParams, which is known to be non-null in org.chromium.content
.browser.SandboxedProcessConnection.doConnectionSetup() Redundant null check at
SandboxedProcessConnection.java |
| 5 H D ST: Write to static field org.chromium.content.app.SandboxedProcessService.s
Context from instance method org.chromium.content.app.SandboxedProcessService.on
Create() At SandboxedProcessService.java | 5 H D ST: Write to static field org.chromium.content.app.SandboxedProcessService.s
Context from instance method org.chromium.content.app.SandboxedProcessService.on
Create() At SandboxedProcessService.java |
| 6 H D ST: Write to static field org.chromium.net.test.util.TestWebServer.sInstance
from instance method org.chromium.net.test.util.TestWebServer.shutdown() At Te
stWebServer.java | 6 H D ST: Write to static field org.chromium.net.test.util.TestWebServer.sInstance
from instance method org.chromium.net.test.util.TestWebServer.shutdown() At Te
stWebServer.java |
| 7 H V MS: org.chromium.android_webview.test.AndroidWebViewTestBase.WAIT_TIMEOUT_SE
CONDS isn't final but should be At AndroidWebViewTestBase.java | 7 H V MS: org.chromium.android_webview.test.AndroidWebViewTestBase.WAIT_TIMEOUT_SE
CONDS isn't final but should be At AndroidWebViewTestBase.java |
| 8 H V MS: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.WAIT_TIMEOUT_S
ECONDS isn't final but should be At LoadDataWithBaseUrlTest.java | 8 H V MS: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.WAIT_TIMEOUT_S
ECONDS isn't final but should be At LoadDataWithBaseUrlTest.java |
| 9 H V MS: org.chromium.content.app.AppResource.ARRAY_OFFICIAL_COMMAND_LINE isn't f
inal but should be In AppResource.java | |
| 10 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_CORNER
_RADII isn't final but should be In AppResource.java | |
| 11 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_HEIGHT
isn't final but should be In AppResource.java | |
| 12 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_PADDIN
G isn't final but should be In AppResource.java | |
| 13 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_COLORSTRIP_WIDTH
isn't final but should be In AppResource.java | |
| 14 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_FOLD_BORDER isn't
final but should be In AppResource.java | |
| 15 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_FOLD_CORNER_RADII
isn't final but should be In AppResource.java | |
| 16 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_FOLD_SHADOW isn't
final but should be In AppResource.java | |
| 17 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_FOLD_SIZE isn't f
inal but should be In AppResource.java | |
| 18 H V MS: org.chromium.content.app.AppResource.DIMENSION_FAVICON_SIZE isn't final
but should be In AppResource.java | |
| 19 H V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_APP_ICON isn't final
but should be In AppResource.java | |
| 20 H V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_DEFAULT_FAVICON isn't
final but should be In AppResource.java | |
| 21 H V MS: org.chromium.content.app.AppResource.ID_DATE_PICKER isn't final but shou
ld be In AppResource.java | |
| 22 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_BUTTON_CANCEL is
n't final but should be In AppResource.java | |
| 23 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_BUTTON_CONFIRM i
sn't final but should be In AppResource.java | |
| 24 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_CHECKBOX_SUPPRES
S_DIALOGS isn't final but should be In AppResource.java | |
| 25 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_TEXT_MESSAGE isn
't final but should be In AppResource.java | |
| 26 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_TEXT_PROMPT isn'
t final but should be In AppResource.java | |
| 27 H V MS: org.chromium.content.app.AppResource.ID_JS_MODAL_DIALOG_TEXT_TITLE isn't
final but should be In AppResource.java | |
| 28 H V MS: org.chromium.content.app.AppResource.ID_MONTH_PICKER isn't final but sho
uld be In AppResource.java | |
| 29 H V MS: org.chromium.content.app.AppResource.ID_MONTH_YEAR_PICKERS_CONTAINER isn
't final but should be In AppResource.java | |
| 30 H V MS: org.chromium.content.app.AppResource.ID_TIME_PICKER isn't final but shou
ld be In AppResource.java | |
| 31 H V MS: org.chromium.content.app.AppResource.ID_YEAR_PICKER isn't final but shou
ld be In AppResource.java | |
| 32 H V MS: org.chromium.content.app.AppResource.LAYOUT_DATE_TIME_PICKER_DIALOG isn'
t final but should be In AppResource.java | |
| 33 H V MS: org.chromium.content.app.AppResource.LAYOUT_JS_MODAL_DIALOG isn't final
but should be In AppResource.java | |
| 34 H V MS: org.chromium.content.app.AppResource.LAYOUT_MONTH_PICKER isn't final but
should be In AppResource.java | |
| 35 H V MS: org.chromium.content.app.AppResource.LAYOUT_MONTH_PICKER_DIALOG isn't fi
nal but should be In AppResource.java | |
| 36 H V MS: org.chromium.content.app.AppResource.MIPMAP_BOOKMARK_SHORTCUT_BACKGROUND
isn't final but should be In AppResource.java | |
| 37 H V MS: org.chromium.content.app.AppResource.STRING_DATE_PICKER_DIALOG_CLEAR isn
't final but should be In AppResource.java | |
| 38 H V MS: org.chromium.content.app.AppResource.STRING_DATE_PICKER_DIALOG_SET isn't
final but should be In AppResource.java | |
| 39 H V MS: org.chromium.content.app.AppResource.STRING_DATE_TIME_PICKER_DIALOG_TITL
E isn't final but should be In AppResource.java | |
| 40 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_DONT_RELOAD_
THIS_PAGE isn't final but should be In AppResource.java | |
| 41 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_LEAVE_THIS_P
AGE isn't final but should be In AppResource.java | |
| 42 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_RELOAD_THIS_
PAGE isn't final but should be In AppResource.java | |
| 43 H V MS: org.chromium.content.app.AppResource.STRING_JS_MODAL_DIALOG_STAY_ON_THIS
_PAGE isn't final but should be In AppResource.java | |
| 44 H V MS: org.chromium.content.app.AppResource.STRING_MONTH_PICKER_DIALOG_TITLE is
n't final but should be In AppResource.java | |
| 45 H V MS: org.chromium.content.browser.ContentViewTestBase.WAIT_TIMEOUT_SECONDS is
n't final but should be At ContentViewTestBase.java | 9 H V MS: org.chromium.content.browser.ContentViewTestBase.WAIT_TIMEOUT_SECONDS is
n't final but should be At ContentViewTestBase.java |
| 46 H V MS: org.chromium.content.browser.test.util.CallbackHelper.WAIT_TIMEOUT_SECON
DS isn't final but should be At CallbackHelper.java | 10 H V MS: org.chromium.content.browser.test.util.CallbackHelper.WAIT_TIMEOUT_SECON
DS isn't final but should be At CallbackHelper.java |
| 47 H V MS: org.chromium.content.browser.test.util.HistoryUtils.WAIT_TIMEOUT_SECONDS
isn't final but should be At HistoryUtils.java | 11 H V MS: org.chromium.content.browser.test.util.HistoryUtils.WAIT_TIMEOUT_SECONDS
isn't final but should be At HistoryUtils.java |
| 48 M B FS: Format string should use %n rather than \n in org.chromium.android_webvi
ew.test.AwSettingsTest.testUserAgentStringDefault() At AwSettingsTest.java | 12 M B FS: Format string should use %n rather than \n in org.chromium.android_webvi
ew.test.AwSettingsTest.testUserAgentStringDefault() At AwSettingsTest.java |
| 49 M B Nm: The class name org.chromium.chrome.browser.component.navigation_intercep
tion.InterceptNavigationDelegate shadows the simple name of implemented interfac
e org.chromium.content.components.navigation_interception.InterceptNavigationDel
egate In InterceptNavigationDelegate.java | 13 M B Nm: The class name org.chromium.chrome.browser.component.navigation_intercep
tion.InterceptNavigationDelegate shadows the simple name of implemented interfac
e org.chromium.content.components.navigation_interception.InterceptNavigationDel
egate In InterceptNavigationDelegate.java |
| 50 M B Nm: The method name org.chromium.base.test.util.ScalableTimeout.ScaleTimeout
(long) doesn't start with a lower case letter At ScalableTimeout.java | 14 M B Nm: The method name org.chromium.base.test.util.ScalableTimeout.ScaleTimeout
(long) doesn't start with a lower case letter At ScalableTimeout.java |
| 51 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.doArchiveTest(AwContents, String, boolean, St
ring) At ArchiveTest.java | 15 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.doArchiveTest(AwContents, String, boolean, St
ring) At ArchiveTest.java |
| 52 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testAutoBadPath() At ArchiveTest.java | 16 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testAutoBadPath() At ArchiveTest.java |
| 53 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testExplicitBadPath() At ArchiveTest.java | 17 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testExplicitBadPath() At ArchiveTest.java |
| 54 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testExplicitGoodPath() At ArchiveTest.java | 18 M B RV: exceptional return value of java.io.File.delete() ignored in org.chromiu
m.android_webview.test.ArchiveTest.testExplicitGoodPath() At ArchiveTest.java |
| (...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 165 M P UuF: Unused field: org.chromium.content.browser.JavaBridgeBasicsTest$23.fiel
d In JavaBridgeBasicsTest.java | 129 M P UuF: Unused field: org.chromium.content.browser.JavaBridgeBasicsTest$23.fiel
d In JavaBridgeBasicsTest.java |
| 166 M V EI2: new org.chromium.chrome.browser.FindMatchRectsDetails(int, RectF[], Rec
tF) may expose internal representation by storing an externally mutable object i
nto FindMatchRectsDetails.rects At FindMatchRectsDetails.java | 130 M V EI2: new org.chromium.chrome.browser.FindMatchRectsDetails(int, RectF[], Rec
tF) may expose internal representation by storing an externally mutable object i
nto FindMatchRectsDetails.rects At FindMatchRectsDetails.java |
| 167 M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setFavic
on(byte[]) may expose internal representation by storing an externally mutable o
bject into ChromeBrowserProvider$BookmarkNode.mFavicon At ChromeBrowserProvider
.java | 131 M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setFavic
on(byte[]) may expose internal representation by storing an externally mutable o
bject into ChromeBrowserProvider$BookmarkNode.mFavicon At ChromeBrowserProvider
.java |
| 168 M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setThumb
nail(byte[]) may expose internal representation by storing an externally mutable
object into ChromeBrowserProvider$BookmarkNode.mThumbnail At ChromeBrowserProv
ider.java | 132 M V EI2: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.setThumb
nail(byte[]) may expose internal representation by storing an externally mutable
object into ChromeBrowserProvider$BookmarkNode.mThumbnail At ChromeBrowserProv
ider.java |
| 169 M V EI2: org.chromium.content.browser.LoadUrlParams.setPostData(byte[]) may expo
se internal representation by storing an externally mutable object into LoadUrlP
arams.mPostData At LoadUrlParams.java | 133 M V EI2: org.chromium.content.browser.LoadUrlParams.setPostData(byte[]) may expo
se internal representation by storing an externally mutable object into LoadUrlP
arams.mPostData At LoadUrlParams.java |
| 170 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.favicon()
may expose internal representation by returning ChromeBrowserProvider$BookmarkN
ode.mFavicon At ChromeBrowserProvider.java | 134 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.favicon()
may expose internal representation by returning ChromeBrowserProvider$BookmarkN
ode.mFavicon At ChromeBrowserProvider.java |
| 171 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.thumbnail
() may expose internal representation by returning ChromeBrowserProvider$Bookmar
kNode.mThumbnail At ChromeBrowserProvider.java | 135 M V EI: org.chromium.chrome.browser.ChromeBrowserProvider$BookmarkNode.thumbnail
() may expose internal representation by returning ChromeBrowserProvider$Bookmar
kNode.mThumbnail At ChromeBrowserProvider.java |
| 172 M V MS: org.chromium.android_webview.AwResource.RAW_LOAD_ERROR isn't final and c
an't be protected from malicious code In AwResource.java | 136 M V MS: org.chromium.android_webview.AwResource.RAW_LOAD_ERROR isn't final and c
an't be protected from malicious code In AwResource.java |
| 173 M V MS: org.chromium.android_webview.AwResource.RAW_NO_DOMAIN isn't final and ca
n't be protected from malicious code In AwResource.java | 137 M V MS: org.chromium.android_webview.AwResource.RAW_NO_DOMAIN isn't final and ca
n't be protected from malicious code In AwResource.java |
| 174 M V MS: org.chromium.android_webview.AwResource.STRING_DEFAULT_TEXT_ENCODING isn
't final and can't be protected from malicious code In AwResource.java | 138 M V MS: org.chromium.android_webview.AwResource.STRING_DEFAULT_TEXT_ENCODING isn
't final and can't be protected from malicious code In AwResource.java |
| 175 M V MS: org.chromium.content.app.AppResource.DIMENSION_LINK_PREVIEW_OVERLAY_RADI
US isn't final and can't be protected from malicious code In AppResource.java | |
| 176 M V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_ACTION_BAR_SHARE isn'
t final and can't be protected from malicious code In AppResource.java | |
| 177 M V MS: org.chromium.content.app.AppResource.DRAWABLE_ICON_ACTION_BAR_WEB_SEARCH
isn't final and can't be protected from malicious code In AppResource.java | |
| 178 M V MS: org.chromium.content.app.AppResource.DRAWABLE_LINK_PREVIEW_POPUP_OVERLAY
isn't final and can't be protected from malicious code In AppResource.java | |
| 179 M V MS: org.chromium.content.app.AppResource.ID_AUTOFILL_LABEL isn't final and c
an't be protected from malicious code In AppResource.java | |
| 180 M V MS: org.chromium.content.app.AppResource.ID_AUTOFILL_NAME isn't final and ca
n't be protected from malicious code In AppResource.java | |
| 181 M V MS: org.chromium.content.app.AppResource.LAYOUT_AUTOFILL_TEXT isn't final an
d can't be protected from malicious code In AppResource.java | |
| 182 M V MS: org.chromium.content.app.AppResource.STRING_ACTION_BAR_SHARE isn't final
and can't be protected from malicious code In AppResource.java | |
| 183 M V MS: org.chromium.content.app.AppResource.STRING_ACTION_BAR_WEB_SEARCH isn't
final and can't be protected from malicious code In AppResource.java | |
| 184 M V MS: org.chromium.content.app.AppResource.STRING_CONTENT_VIEW_CONTENT_DESCRIP
TION isn't final and can't be protected from malicious code In AppResource.jav
a | |
| 185 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_BUTTON is
n't final and can't be protected from malicious code In AppResource.java | |
| 186 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_ERROR_TITLE isn
't final and can't be protected from malicious code In AppResource.java | |
| 187 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_LOADING_VIDEO i
sn't final and can't be protected from malicious code In AppResource.java | |
| 188 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_PLAYBAC
K_ERROR isn't final and can't be protected from malicious code In AppResource.
java | |
| 189 M V MS: org.chromium.content.app.AppResource.STRING_MEDIA_PLAYER_MESSAGE_UNKNOWN
_ERROR isn't final and can't be protected from malicious code In AppResource.j
ava | |
| 190 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_H
TTP_POST should be package protected In LoadUrlParams.java | 139 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_BROWSER_INITIATED_H
TTP_POST should be package protected In LoadUrlParams.java |
| 191 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final an
d can't be protected from malicious code In LoadUrlParams.java | 140 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DATA isn't final an
d can't be protected from malicious code In LoadUrlParams.java |
| 192 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be p
ackage protected In LoadUrlParams.java | 141 M V MS: org.chromium.content.browser.LoadUrlParams.LOAD_TYPE_DEFAULT should be p
ackage protected In LoadUrlParams.java |
| 193 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be
package protected In LoadUrlParams.java | 142 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be
package protected In LoadUrlParams.java |
| 194 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be pa
ckage protected In LoadUrlParams.java | 143 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE should be pa
ckage protected In LoadUrlParams.java |
| 195 M C RCN: Nullcheck of GestureDetector.mVelocityTracker at line 630 of value prev
iously dereferenced in org.chromium.content.browser.third_party.GestureDetector.
onTouchEvent(MotionEvent) At GestureDetector.java | 144 M C RCN: Nullcheck of GestureDetector.mVelocityTracker at line 630 of value prev
iously dereferenced in org.chromium.content.browser.third_party.GestureDetector.
onTouchEvent(MotionEvent) At GestureDetector.java |
| 196 M D SF: Switch statement found in org.chromium.content.browser.third_party.Gestu
reDetector.onTouchEvent(MotionEvent) where default case is missing At GestureDe
tector.java | 145 M D SF: Switch statement found in org.chromium.content.browser.third_party.Gestu
reDetector.onTouchEvent(MotionEvent) where default case is missing At GestureDe
tector.java |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 11360207:
Add Java resources to content and chrome. (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src