Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11150028: Add new VS AddIn examples (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
noelallen1, binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add new VS AddIn examples. BUG=

Patch Set 1 #

Total comments: 61

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1283 lines, -213 lines) Patch
M .gitignore View 2 chunks +12 lines, -11 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln View 1 1 chunk +38 lines, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.c View 1 1 chunk +404 lines, -0 lines 1 comment Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.vcxproj View 1 4 chunks +105 lines, -54 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/index.html View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp.sln View 1 1 chunk +38 lines, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc View 1 2 1 chunk +364 lines, -0 lines 2 comments Download
A + visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj View 1 1 chunk +199 lines, -148 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.vcxproj.user View 1 1 chunk +19 lines, -0 lines 0 comments Download
A visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/index.html View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M visual_studio/NativeClientVSAddIn/NativeClientVSAddIn/PropertyManager.cs View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-15 21:50:48 UTC) #1
binji
http://codereview.chromium.org/11150028/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln File visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln (right): http://codereview.chromium.org/11150028/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln#newcode8 visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln:8: Debug|NaCl64 = Debug|NaCl64 add NaCl32 http://codereview.chromium.org/11150028/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.c File visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.c (right): ...
8 years, 2 months ago (2012-10-15 22:15:46 UTC) #2
Sam Clegg
http://codereview.chromium.org/11150028/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln File visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln (right): http://codereview.chromium.org/11150028/diff/1/visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln#newcode8 visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl.sln:8: Debug|NaCl64 = Debug|NaCl64 On 2012/10/15 22:15:46, binji wrote: > ...
8 years, 2 months ago (2012-10-15 22:54:52 UTC) #3
binji
8 years, 2 months ago (2012-10-15 23:03:07 UTC) #4
lgtm

http://codereview.chromium.org/11150028/diff/9001/visual_studio/NativeClientV...
File
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.c
(right):

http://codereview.chromium.org/11150028/diff/9001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl/hello_nacl/hello_nacl.c:353:
int InitInstanceInPCWindow()
brace on this line

http://codereview.chromium.org/11150028/diff/9001/visual_studio/NativeClientV...
File
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc
(right):

http://codereview.chromium.org/11150028/diff/9001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:202:
int nCmdShow)
brace this line

http://codereview.chromium.org/11150028/diff/9001/visual_studio/NativeClientV...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:259:
LRESULT CALLBACK WndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
brace this line

Powered by Google App Engine
This is Rietveld 408576698