Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10995: * Remove an unused layer of abstraction by not having both a macro assembler ... (Closed)

Created:
12 years ago by Erik Corry
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

* Remove an unused layer of abstraction by not having both a macro assembler and an assembler when compiling to bytecode. This fixes http://code.google.com/p/v8/issues/detail?id=165 * Preload the 'current character' register when starting a match (byte code only at the moment). Committed: http://code.google.com/p/v8/source/detail?r=865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -842 lines) Patch
M src/SConscript View 1 chunk +14 lines, -14 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
D src/assembler-irregexp.h View 1 chunk +0 lines, -164 lines 0 comments Download
D src/assembler-irregexp.cc View 1 chunk +0 lines, -357 lines 0 comments Download
D src/assembler-irregexp-inl.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/interpreter-irregexp.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M src/jsregexp.cc View 2 chunks +1 line, -3 lines 1 comment Download
M src/regexp-macro-assembler-irregexp.h View 2 chunks +33 lines, -4 lines 0 comments Download
M src/regexp-macro-assembler-irregexp.cc View 8 chunks +149 lines, -46 lines 0 comments Download
A + src/regexp-macro-assembler-irregexp-inl.h View 4 chunks +3 lines, -17 lines 0 comments Download
M test/cctest/test-regexp.cc View 3 chunks +2 lines, -140 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
12 years ago (2008-11-28 10:02:25 UTC) #1
Christian Plesner Hansen
12 years ago (2008-11-28 10:13:25 UTC) #2
Yawn.  Lgtm.

http://codereview.chromium.org/10995/diff/1/13
File src/jsregexp.cc (right):

http://codereview.chromium.org/10995/diff/1/13#newcode2732
Line 2732: byte codes[1024];
You can use EmbeddedVector<byte, 1024> instead.

Powered by Google App Engine
This is Rietveld 408576698