src/jsregexp.cc - Issue 10995: * Remove an unused layer of abstraction by not having both a macro assembler ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/jsregexp.cc

Issue 10995: * Remove an unused layer of abstraction by not having both a macro assembler ... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/jsregexp.cc

===================================================================

--- src/jsregexp.cc (revision 862)

+++ src/jsregexp.cc (working copy)

@@ -40,7 +40,6 @@

#include "compilation-cache.h"

#include "string-stream.h"

#include "parser.h"

-#include "assembler-irregexp.h"

#include "regexp-macro-assembler.h"

#include "regexp-macro-assembler-tracer.h"

#include "regexp-macro-assembler-irregexp.h"

@@ -2731,8 +2730,7 @@

#endif

}

byte codes[1024];

Christian Plesner Hansen 2008/11/28 10:13:25 You can use EmbeddedVector<byte, 1024> instead.

- IrregexpAssembler assembler(Vector<byte>(codes, 1024));

- RegExpMacroAssemblerIrregexp macro_assembler(&assembler);

+ RegExpMacroAssemblerIrregexp macro_assembler(Vector<byte>(codes, 1024));

return compiler.Assemble(&macro_assembler,

node,

input->capture_count);

« no previous file with comments | « src/interpreter-irregexp.cc ('k') | src/regexp-macro-assembler-irregexp.h » ('j') | no next file with comments »