* Remove an unused layer of abstraction by not having both a macro assembler ...

test/cctest/test-regexp.cc

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 18 matching lines @@
 #include <stdlib.h>
 #include <set>
 
 #include "v8.h"
 
 #include "cctest.h"
 #include "zone-inl.h"
 #include "parser.h"
 #include "ast.h"
 #include "jsregexp-inl.h"
-#include "assembler-irregexp.h"
 #include "regexp-macro-assembler.h"
 #include "regexp-macro-assembler-irregexp.h"
 #ifdef ARM
 #include "regexp-macro-assembler-arm.h"
 #else  // IA32
 #include "macro-assembler-ia32.h"
 #include "regexp-macro-assembler-ia32.h"
 #endif
 #include "interpreter-irregexp.h"
 
@@ skipping 462 matching lines @@
       uc16* range = ranges[j];
       bool is_on = false;
       for (int k = 0; !is_on && (k < 2 * kRangeSize); k += 2)
         is_on = (range[k] <= p && p <= range[k + 1]);
       CHECK_EQ(is_on, outs->Get(j));
     }
   }
 }
 
 
-TEST(Assembler) {
-  V8::Initialize(NULL);
-  byte codes[1024];
-  IrregexpAssembler assembler(Vector<byte>(codes, 1024));
-#define __ assembler.
-  Label advance;
-  Label look_for_foo;
-  Label fail;
-  __ GoTo(&look_for_foo);
-  __ Bind(&advance);
-  __ AdvanceCP(1);
-  __ Bind(&look_for_foo);
-  __ LoadCurrentChar(0, &fail);
-  __ CheckNotCharacter('f', &advance);
-  __ LoadCurrentChar(1, &fail);
-  __ CheckNotCharacter('o', &advance);
-  __ LoadCurrentChar(2, &fail);
-  __ CheckNotCharacter('o', &advance);
-  __ WriteCurrentPositionToRegister(0);
-  __ WriteCurrentPositionToRegister(1, 2);
-  __ Succeed();
-  __ Bind(&fail);
-  __ Fail();
-
-  v8::HandleScope scope;
-  Handle<ByteArray> array = Factory::NewByteArray(assembler.length());
-  assembler.Copy(array->GetDataStartAddress());
-  int captures[2];
-
-  Handle<String> f1 =
-      Factory::NewStringFromAscii(CStrVector("Now is the time"));
-  Handle<String> f1_16 = RegExpImpl::StringToTwoByte(f1);
-  CHECK(!IrregexpInterpreter::Match(array, f1_16, captures, 0));
-
-  Handle<String> f2 = Factory::NewStringFromAscii(CStrVector("foo bar baz"));
-  Handle<String> f2_16 = RegExpImpl::StringToTwoByte(f2);
-  CHECK(IrregexpInterpreter::Match(array, f2_16, captures, 0));
-  CHECK_EQ(0, captures[0]);
-  CHECK_EQ(2, captures[1]);
-
-  Handle<String> f3 = Factory::NewStringFromAscii(CStrVector("tomfoolery"));
-  Handle<String> f3_16 = RegExpImpl::StringToTwoByte(f3);
-  CHECK(IrregexpInterpreter::Match(array, f3_16, captures, 0));
-  CHECK_EQ(3, captures[0]);
-  CHECK_EQ(5, captures[1]);
-}
-
-
-TEST(Assembler2) {
-  V8::Initialize(NULL);
-  byte codes[1024];
-  IrregexpAssembler assembler(Vector<byte>(codes, 1024));
-#define __ assembler.
-  // /^.*foo/
-  Label more_dots;
-  Label unwind_dot;
-  Label failure;
-  Label foo;
-  Label foo_failed;
-  Label dot_match;
-  // ^
-  __ PushCurrentPosition();
-  __ PushRegister(0);
-  __ WriteCurrentPositionToRegister(0);
-  __ PushBacktrack(&failure);
-  __ GoTo(&dot_match);
-  // .*
-  __ Bind(&more_dots);
-  __ AdvanceCP(1);
-  __ Bind(&dot_match);
-  __ PushCurrentPosition();
-  __ PushBacktrack(&unwind_dot);
-  __ LoadCurrentChar(0, &foo);
-  __ CheckNotCharacter('\n', &more_dots);
-  // foo
-  __ Bind(&foo);
-  __ CheckNotCharacter('f', &foo_failed);
-  __ LoadCurrentChar(1, &foo_failed);
-  __ CheckNotCharacter('o', &foo_failed);
-  __ LoadCurrentChar(2, &foo_failed);
-  __ CheckNotCharacter('o', &foo_failed);
-  __ WriteCurrentPositionToRegister(1, 2);
-  __ Succeed();
-  __ Break();
-
-  __ Bind(&foo_failed);
-  __ PopBacktrack();
-  __ Break();
-
-  __ Bind(&unwind_dot);
-  __ PopCurrentPosition();
-  __ LoadCurrentChar(0, &foo_failed);
-  __ GoTo(&foo);
-
-  __ Bind(&failure);
-  __ PopRegister(0);
-  __ PopCurrentPosition();
-  __ Fail();
-
-  v8::HandleScope scope;
-  Handle<ByteArray> array = Factory::NewByteArray(assembler.length());
-  assembler.Copy(array->GetDataStartAddress());
-  int captures[2];
-
-  Handle<String> f1 =
-      Factory::NewStringFromAscii(CStrVector("Now is the time"));
-  Handle<String> f1_16 = RegExpImpl::StringToTwoByte(f1);
-  CHECK(!IrregexpInterpreter::Match(array, f1_16, captures, 0));
-
-  Handle<String> f2 = Factory::NewStringFromAscii(CStrVector("foo bar baz"));
-  Handle<String> f2_16 = RegExpImpl::StringToTwoByte(f2);
-  CHECK(IrregexpInterpreter::Match(array, f2_16, captures, 0));
-  CHECK_EQ(0, captures[0]);
-  CHECK_EQ(2, captures[1]);
-
-  Handle<String> f3 = Factory::NewStringFromAscii(CStrVector("tomfoolery"));
-  Handle<String> f3_16 = RegExpImpl::StringToTwoByte(f3);
-  CHECK(IrregexpInterpreter::Match(array, f3_16, captures, 0));
-  CHECK_EQ(0, captures[0]);
-  CHECK_EQ(5, captures[1]);
-
-  Handle<String> f4 =
-      Factory::NewStringFromAscii(CStrVector("football buffoonery"));
-  Handle<String> f4_16 = RegExpImpl::StringToTwoByte(f4);
-  CHECK(IrregexpInterpreter::Match(array, f4_16, captures, 0));
-  CHECK_EQ(0, captures[0]);
-  CHECK_EQ(14, captures[1]);
-
-  Handle<String> f5 =
-      Factory::NewStringFromAscii(CStrVector("walking\nbarefoot"));
-  Handle<String> f5_16 = RegExpImpl::StringToTwoByte(f5);
-  CHECK(!IrregexpInterpreter::Match(array, f5_16, captures, 0));
-}
-
-
 TEST(MacroAssembler) {
   V8::Initialize(NULL);
   byte codes[1024];
-  IrregexpAssembler assembler(Vector<byte>(codes, 1024));
-  RegExpMacroAssemblerIrregexp m(&assembler);
+  RegExpMacroAssemblerIrregexp m(Vector<byte>(codes, 1024));
   // ^f(o)o.
   Label fail, fail2, start;
   uc16 foo_chars[3];
   foo_chars[0] = 'f';
   foo_chars[1] = 'o';
   foo_chars[2] = 'o';
   Vector<const uc16> foo(foo_chars, 3);
   m.SetRegister(4, 42);
   m.PushRegister(4);
   m.AdvanceRegister(4, 42);
@@ skipping 16 matching lines @@
   m.Bind(&fail);
   m.Backtrack();
   m.Succeed();
 
   m.Bind(&fail2);
   m.PopRegister(0);
   m.Fail();
 
   v8::HandleScope scope;
 
-  Handle<ByteArray> array = Factory::NewByteArray(assembler.length());
-  assembler.Copy(array->GetDataStartAddress());
+  Handle<ByteArray> array = Handle<ByteArray>::cast(m.GetCode());
   int captures[5];
 
   Handle<String> f1 =
       Factory::NewStringFromAscii(CStrVector("foobar"));
   Handle<String> f1_16 = RegExpImpl::StringToTwoByte(f1);
   CHECK(IrregexpInterpreter::Match(array, f1_16, captures, 0));
   CHECK_EQ(0, captures[0]);
   CHECK_EQ(3, captures[1]);
   CHECK_EQ(1, captures[2]);
   CHECK_EQ(2, captures[3]);
@@ skipping 511 matching lines @@
   // whole block at a time.
   TestSimpleRangeCaseIndependence(CharacterRange('A', 'k'),
                                   CharacterRange('a', 'z'));
 }
 
 
 TEST(Graph) {
   V8::Initialize(NULL);
   Execute("foo$(?!bar)", false, true);
 }